1534256 - Wrong support webpage is displayed after clicking the about:preferences help buttons

Status: VERIFIED FIXED

(Firefox :: Preferences, defect, P1)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: supportwebpage.gif

Affected versions

• Firefox 67.0a1 (BuildId:20190311102806).

Unaffected versions

• Firefox 60.5.0esr (BuildId:20190124141046).
• Firefox 66.0b14 (BuildID:20190307095232).
• Firefox 65.0 (BuildId:20190124174741).

Affected platforms

• Windows 10 64bit.
• macOS 10.11.6
• Ubuntu 18.04 64bit.

Steps to reproduce

1. Launch Firefox.
2. Access the about:preferences page.
3. Click the “Choose” button from the “Language and Appearance” section.
4. Click the "Help" button.

Expected result

• The opened support webpage contains the information related to the section from where the help button was clicked.
• The following wepbage is displayed : Link

Actual result

• The following webpage is displayed: Link

Regression range
This seems to be a regression.

• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4ab143dde4dc3424cfedc74b3648fbf2e47fb7bf&tochange=ba3dfc81120d01a3e931697d72e6bd95dad09582

• Potential regressor: Bug 1532685

Additional notes

• Please note that 66 will be affected as well (once Bug 1532685) gets uplifted.
• For further information regarding this issue, please observe the attached screencast.

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Gijs,

I think that the fix for Bug 1532685 may have introduced this regression.

Can you please have a look?

Thanks!

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1534256 - actually open the right help topic page, r?jaws!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af2e51990c3d
actually open the right help topic page, r=jaws

Comment 4

[:Gijs (he/him)]

Comment on attachment 9049978 [details]
Bug 1534256 - actually open the right help topic page, r?jaws!

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1532685
• User impact if declined: The help button now opens only 1 tab (good! fixes regression from bug 1521040) but opens the generic sumo homepage in the user's locale instead of a topical page (bad!)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment #0
• List of other uplifts needed: n/a
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): The patch itself is straightforward, but I said that last time... I took the opportunity to clean up a difference between windows/linux and mac, so now these help pages will always open in a new tab instead of a new window.
• String changes made/needed: nope

Comment 5

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 9049978 [details]
Bug 1534256 - actually open the right help topic page, r?jaws!

Fix for regression in 66, OK for uplift.

Comment 6

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/9faa04ade14a

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/af2e51990c3d

Comment 8

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 67.0a1 (BuildId:20190312095443) and Firefox 66.0 (BuildId:20190311211048) on Windows 10 64bit, macOS 10.12.6 and Ubuntu 16.04 32bit.