Wrong support webpage is displayed after clicking the about:preferences help buttons

VERIFIED FIXED in Firefox 66

Status

()

defect
P1
normal
VERIFIED FIXED
2 months ago
2 months ago

People

(Reporter: emilghitta, Assigned: Gijs)

Tracking

({regression})

67 Branch
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox65 unaffected, firefox66+ verified, firefox67 verified)

Details

Attachments

(2 attachments)

Reporter

Description

2 months ago
Posted image supportwebpage.gif

Affected versions

  • Firefox 67.0a1 (BuildId:20190311102806).

Unaffected versions

  • Firefox 60.5.0esr (BuildId:20190124141046).
  • Firefox 66.0b14 (BuildID:20190307095232).
  • Firefox 65.0 (BuildId:20190124174741).

Affected platforms

  • Windows 10 64bit.
  • macOS 10.11.6
  • Ubuntu 18.04 64bit.

Steps to reproduce

  1. Launch Firefox.
  2. Access the about:preferences page.
  3. Click the “Choose” button from the “Language and Appearance” section.
  4. Click the "Help" button.

Expected result

  • The opened support webpage contains the information related to the section from where the help button was clicked.
  • The following wepbage is displayed : Link

Actual result

  • The following webpage is displayed: Link

Regression range
This seems to be a regression.

Additional notes

  • Please note that 66 will be affected as well (once Bug 1532685) gets uplifted.
  • For further information regarding this issue, please observe the attached screencast.
Reporter

Comment 1

2 months ago

Hi Gijs,

I think that the fix for Bug 1532685 may have introduced this regression.

Can you please have a look?

Thanks!

Flags: needinfo?(gijskruitbosch+bugs)
Reporter

Updated

2 months ago
Has Regression Range: --- → yes
Has STR: --- → yes
Assignee

Updated

2 months ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)

Comment 3

2 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/af2e51990c3d
actually open the right help topic page, r=jaws
Assignee

Comment 4

2 months ago

Comment on attachment 9049978 [details]
Bug 1534256 - actually open the right help topic page, r?jaws!

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1532685
  • User impact if declined: The help button now opens only 1 tab (good! fixes regression from bug 1521040) but opens the generic sumo homepage in the user's locale instead of a topical page (bad!)
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment #0
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): The patch itself is straightforward, but I said that last time... I took the opportunity to clean up a difference between windows/linux and mac, so now these help pages will always open in a new tab instead of a new window.
  • String changes made/needed: nope
Attachment #9049978 - Flags: approval-mozilla-beta?
Assignee

Updated

2 months ago
Priority: -- → P1

Comment on attachment 9049978 [details]
Bug 1534256 - actually open the right help topic page, r?jaws!

Fix for regression in 66, OK for uplift.

Attachment #9049978 - Flags: approval-mozilla-release+
Attachment #9049978 - Flags: approval-mozilla-beta?
Attachment #9049978 - Flags: approval-mozilla-beta-

Comment 7

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
QA Whiteboard: [qa-triaged]
Reporter

Comment 8

2 months ago

This issue is verified fixed using Firefox 67.0a1 (BuildId:20190312095443) and Firefox 66.0 (BuildId:20190311211048) on Windows 10 64bit, macOS 10.12.6 and Ubuntu 16.04 32bit.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.