Closed Bug 1534304 Opened 2 years ago Closed 2 years ago

Proper fix for race condition in devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_telemetry_runtime_updates.js

Categories

(DevTools :: about:debugging, enhancement)

enhancement
Not set
normal

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

Details

Attachments

(1 file)

Spun off from bug 1533574, in which I landed a workaround that doesn't really fix the bug. jdescottes pointed out the real issue on review:

I think the issue is that since I landed the original fix we now change the runtime name displayed after connection / disconnection.

So the removeUSB helper should check both that runtime.name and runtime.shortname are not found in the sidebar. Feel free to land this but we should file a follow up to implement the correct fix

Assignee: nobody → jorendorff
See Also: → 1534499
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.