1534304 - Proper fix for race condition in devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_telemetry_runtime_updates.js

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement)

Description

[Jason Orendorff [:jorendorff]]

Spun off from bug 1533574, in which I landed a workaround that doesn't really fix the bug. jdescottes pointed out the real issue on review:

I think the issue is that since I landed the original fix we now change the runtime name displayed after connection / disconnection.

So the removeUSB helper should check both that runtime.name and runtime.shortname are not found in the sidebar. Feel free to land this but we should file a follow up to implement the correct fix

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1534304 - Proper fix for a race condition in an about:debugging test. r?jdescottes

Comment 2

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4d440c866f44

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/4d440c866f4440ff1456835a6836383120d9ed45