Closed Bug 1534310 Opened 5 years ago Closed 5 years ago

Update test_about_private_browsing.py to compare element text to fluent localization text.

Categories

(Testing :: Firefox UI Tests, task, P3)

task

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: nickcowles9575, Unassigned)

References

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.119 Safari/537.36

Steps to reproduce:

Commented out lines 40-43 and lines 98-101 to pass test.

Actual results:

Previously test failed to find element when performing assertion due to relying on DTD style localization references that no longer exist.

Expected results:

Test should pass but must be updated so that assertion compares element text against new fluent style text.

Blocks: 1517528

Can you please give an example in how strings have to be retrieved? Is that similar to string bundles?

Flags: needinfo?(nickcowles9575)

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #1)

Can you please give an example in how strings have to be retrieved? Is that similar to string bundles?

My understanding was that since the new fluent system fetched the strings it needs on demand and asynchronously that a string bundle wouldn’t work. I’m not sure what the better alternative would be for fetching the strings in tests since I don’t know how localization is integrated with the testing frameworks. You can find a bit more info on using Fluent localization here: https://github.com/projectfluent/fluent-web#how-to-use

Flags: needinfo?(nickcowles9575)
Status: UNCONFIRMED → NEW
Type: defect → task
Ever confirmed: true
Priority: -- → P3

This will not happen. See bug 1548777 comment 4 for more details. Until the test has been removed, lets leave those assertions commented out.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.