Keep or replace cert hostname dot (.) separators in certificate export filename

VERIFIED FIXED in Firefox 67

Status

()

defect
P1
normal
VERIFIED FIXED
5 months ago
4 months ago

People

(Reporter: 13hurdw, Assigned: trushita)

Tracking

65 Branch
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 verified)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 attachment)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

Actual results:

Save filename *bugzillamozillaorg.crt

Expected results:

Doesn't strip out the dots in the cert name
*bugzilla.mozilla.org.crt

or replace with underscores *bugzilla_mozilla_org.crt

can I work on this?

Flags: needinfo?(dkeeler)

Certainly.

Assignee: nobody → trushita
Flags: needinfo?(dkeeler)
Priority: P5 → P1
Whiteboard: [psm-would-take] → [psm-assigned]
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

I would like to work on this.

I understand that I can have the file name with either "." separator or "_". which one would be better? Is there any preference in file naming convention to be followed?

Flags: needinfo?(dkeeler)

Let's use underscores ("_")

Flags: needinfo?(dkeeler)

(In reply to Monika Maheshwari [:MonikaMaheshwari] from comment #4)

I would like to work on this.

This is already assigned, so it wouldn't make sense for you to work on this right now.

I am done with the changes. Currently working on installations to submit patch.

I have set up phabricator but apparently I am getting the below error:-

C:\PHP>arc help

PHP CONFIGURATION ERRORS

Your install of PHP does not have the 'php_curl.dll' extension enabled. Edit your php.ini file and uncomment the line which reads 'extension=php_curl.dll'.

I have worked around it but I am still stuck.

Flags: needinfo?(dkeeler)

(In reply to trushita from comment #9)

I have set up phabricator but apparently I am getting the below error:-

C:\PHP>arc help

PHP CONFIGURATION ERRORS

Your install of PHP does not have the 'php_curl.dll' extension enabled. Edit your php.ini file and uncomment the line which reads 'extension=php_curl.dll'.

I have worked around it but I am still stuck.

Its working now.

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Flags: needinfo?(dkeeler)
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

I have submitted the patch. Open to suggestions.

The certificate when exported had filename with no separator. Now added "_" separator to filename.

Attachment #9050960 - Attachment description: Added _ separator in certificate export filename. Bug #:1534337 → Bug 1534337: Add _ separator in certificate export filename.
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9071e6d7836b
Add _ separator in certificate export filename.  r=keeler
Status: REOPENED → RESOLVED
Closed: 5 months ago5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Thanks all for the fast turnaround on this !

(In reply to 13hu from comment #15)

Thanks all for the fast turnaround on this !
sure! :)

QA Whiteboard: [qa-triaged]
Flags: qe-verify+
QA Whiteboard: [qa-triaged]
Whiteboard: [psm-assigned]
Whiteboard: [psm-assigned]

Reproduced the initial issue on Firefox 65.0 on macOS 10.13.6, the name of the cert file is *bugzillamozillaorg.crt

Verified that using latest Firefox beta 67.0b13 and latest Nightly 68.0a1 across platforms, the name of the cert file is *_bugzilla_mozilla_org.crt

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.