1534337 - Keep or replace cert hostname dot (.) separators in certificate export filename

Status: VERIFIED FIXED

(Core :: Security: PSM, defect, P1)

Description

[13hu]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

• https://bugzilla.mozilla.org/ site info
• Security
• More information
• View Certificate -> Details
• Export...

Actual results:

Save filename *bugzillamozillaorg.crt

Expected results:

Doesn't strip out the dots in the cert name
*bugzilla.mozilla.org.crt

or replace with underscores *bugzilla_mozilla_org.crt

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

This is the place where this change would happen: https://searchfox.org/mozilla-central/rev/8ff2cd0a27e3764d9540abdc5a66b2fb1e4e9644/security/manager/pki/resources/content/pippki.js#94

Comment 2

[trushita]

can I work on this?

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Certainly.

Comment 4

[Monika Maheshwari [:MonikaMaheshwari]]

I would like to work on this.

Comment 5

[trushita]

I understand that I can have the file name with either "." separator or "_". which one would be better? Is there any preference in file naming convention to be followed?

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Let's use underscores ("_")

Comment 7

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

(In reply to Monika Maheshwari [:MonikaMaheshwari] from comment #4)

I would like to work on this.

This is already assigned, so it wouldn't make sense for you to work on this right now.

Comment 8

[trushita]

I am done with the changes. Currently working on installations to submit patch.

Comment 9

[trushita]

I have set up phabricator but apparently I am getting the below error:-

C:\PHP>arc help

PHP CONFIGURATION ERRORS

Your install of PHP does not have the 'php_curl.dll' extension enabled. Edit your php.ini file and uncomment the line which reads 'extension=php_curl.dll'.

I have worked around it but I am still stuck.

Comment 10

[trushita]

(In reply to trushita from comment #9)

I have set up phabricator but apparently I am getting the below error:-

C:\PHP>arc help

PHP CONFIGURATION ERRORS

Your install of PHP does not have the 'php_curl.dll' extension enabled. Edit your php.ini file and uncomment the line which reads 'extension=php_curl.dll'.

I have worked around it but I am still stuck.

Its working now.

Comment 11

[trushita]

I have submitted the patch. Open to suggestions.

Comment 12

[trushita]

Attachment: Bug 1534337: Add _ separator in certificate export filename.

The certificate when exported had filename with no separator. Now added "_" separator to filename.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9071e6d7836b
Add _ separator in certificate export filename.  r=keeler

Comment 14

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9071e6d7836b

Comment 15

[13hu]

Thanks all for the fast turnaround on this !

Comment 16

[trushita]

(In reply to 13hu from comment #15)

Thanks all for the fast turnaround on this !
sure! :)

Comment 17

[Bogdan Maris, Desktop QA]

Reproduced the initial issue on Firefox 65.0 on macOS 10.13.6, the name of the cert file is *bugzillamozillaorg.crt

Verified that using latest Firefox beta 67.0b13 and latest Nightly 68.0a1 across platforms, the name of the cert file is *_bugzilla_mozilla_org.crt