Fix symbols.functions and symbols.identifiers getSymbols O(n^2) behavior

RESOLVED FIXED in Firefox 67

Status

Product:
DevTools
Component:
Debugger
Type:
enhancement
Importance:
P1
normal
Status:
RESOLVED FIXED
Reported:
2 months ago
Modified:
15 days ago

People

(Reporter: loganfsmyth, Assigned: loganfsmyth)

Tracking

(Blocks 1 bug)

Version:
Trunk
Target:
Firefox 67

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(2 attachments)

Bug 1534342 - Fix O(n^2) perf issues in getSymbols. r=jlast
47 bytes, text/x-phabricator-request
Details | Review
Bug 1534342 - Fix test flakiness introduced by not blocking on parser.setSource(). r=jlast
47 bytes, text/x-phabricator-request
Details | Review
(Assignee)

Description

•
2 months ago

We have a few noticeable O(n^2) issues in the getSymbols implementation along with one that we already fixed.

Comment 2

•
2 months ago 
Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7dee08698fc
Fix O(n^2) perf issues in getSymbols. r=jlast

Comment 4

•
2 months ago 
Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe49766985d1
Fix test flakiness introduced by not blocking on parser.setSource().

Comment 5

•
2 months ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a7dee08698fc
https://hg.mozilla.org/mozilla-central/rev/fe49766985d1

Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.