Use native maybe support in IPDL instead of OptionalIPCServiceWorkerDescriptor

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)

Tracking

Trunk
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 months ago

This is more readable.

Assignee

Updated

2 months ago
Keywords: checkin-needed

Comment 2

2 months ago

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5beba8cc190
replace OptionalIPCServiceWorkerDescriptor with IPCServiceWorkerDescriptor? in IPDL: r=valentin

Keywords: checkin-needed

And also multiple failures with crash signature [@ mozilla::Maybe<mozilla::dom::IPCServiceWorkerDescriptor>::emplace<mozilla::dom::IPCServiceWorkerDescriptor const&>(mozilla::dom::IPCServiceWorkerDescriptor const&)]

E.g. https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233977802&repo=autoland&lineNumber=3703

Assignee

Comment 5

2 months ago

Let's try that again

Flags: needinfo?(agaynor)
Keywords: checkin-needed

Comment 6

2 months ago

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/56f062d2e373
replace OptionalIPCServiceWorkerDescriptor with IPCServiceWorkerDescriptor? in IPDL: r=valentin

Keywords: checkin-needed

Comment 7

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.