1534366 - Port bug 1531176: Split the Google key management between gls and safe browsing

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Richard Marti (:Paenglab)]

M-C splitted the Google key in about:support.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1534366-aboutSupport-split-Google-key.patch

port of https://hg.mozilla.org/mozilla-central/rev/b59042f5f5bcaf8f7d25511a4407666b26d62da1#l3.1 and https://hg.mozilla.org/mozilla-central/rev/b59042f5f5bcaf8f7d25511a4407666b26d62da1#l3.1

Comment 2

[Jorg K (CEST = GMT+2)]

Actually, the second hunk is from here: https://hg.mozilla.org/mozilla-central/rev/43376e0c3563#l17.12.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9050065 [details] [diff] [review]
1534366-aboutSupport-split-Google-key.patch

Thanks. Do we see this information in TB?

Comment 4

[Richard Marti (:Paenglab)]

It shows "Missing" as we don't have this key.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/428771c644a3
Port bug 1531176: Split the Google key management between gls and safe browsing. r=jorgk

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9050065 [details] [diff] [review]
1534366-aboutSupport-split-Google-key.patch

You wouldn't believe it but bug 1531176 was uplifted to m-esr60 and without this uplift I get:
XML Parsing Error: undefined entity Location: jar:file:///C:/Program%20Files%20(x86)/Mozilla%20Thunderbird%2060.6/omni.ja!/chrome/messenger/content/messenger/about-support/aboutSupport.xhtml Line Number 265, Column 15:
              &aboutSupport.appBasicsKeyGoogle;

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: ESR60 version

Comment 8

[Jorg K (CEST = GMT+2)]

TB 60.6 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/42e5961ce7b8186480e4f840257b5efd8aca8abe

Comment 9

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/comm-esr60/rev/e6447e70d1db7e1ff9aa3fa4359fedb124b2626f - Follow-up :-(