Closed Bug 1534368 Opened 9 months ago Closed 9 months ago

source-maps.js getSelectedLocation should return null if there is no location matching the context

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: loganfsmyth, Assigned: jlast)

References

Details

Attachments

(1 file, 1 obsolete file)

We pass mappedLocation and an optional context to getSelectedLocation, but there is still a risk that even if isOriginalId(sourceId) that mappedLocation.location.sourceId !== sourceId and we should probably return null in that context.

Otherwise we risk pulling in a location that does not match our expectations.

Priority: -- → P3
Attachment #9051845 - Attachment is obsolete: true
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7061dad8da97
breakpoint positions should be filtered by source. r=loganfsmyth
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Assignee: nobody → jlaster
https://hg.mozilla.org/projects/ash/rev/7061dad8da97e6e6067bb5d99bc07a6d01d1b19a
Bug 1534368 - breakpoint positions should be filtered by source. r=loganfsmyth
You need to log in before you can comment on or make changes to this bug.