1534368 - source-maps.js getSelectedLocation should return null if there is no location matching the context

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Logan Smyth [:loganfsmyth]]

We pass mappedLocation and an optional context to getSelectedLocation, but there is still a risk that even if isOriginalId(sourceId) that mappedLocation.location.sourceId !== sourceId and we should probably return null in that context.

Otherwise we risk pulling in a location that does not match our expectations.

Comment 1

[Jason Laster [:jlast]]

Attachment: Bug 1534368 - source-maps.js getSelectedLocation should return null if there is no location matching the context. r=loganfsmyth

Comment 2

[Jason Laster [:jlast]]

Attachment: Bug 1534368 - breakpoint positions should be filtered by source. r=loganfsmyth

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7061dad8da97
breakpoint positions should be filtered by source. r=loganfsmyth

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7061dad8da97

Comment 5

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/7061dad8da97e6e6067bb5d99bc07a6d01d1b19a
Bug 1534368 - breakpoint positions should be filtered by source. r=loganfsmyth