Closed Bug 1534391 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 15511 - [css-grid] Always consider baseline shim for the minimum contribution

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15511 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15511
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-grid] Always consider baseline shim for the minimum contribution

Before this patch, the shim used for baseline alignment is not taken
into consideration when calculating the minimum contribution of a grid
item if its preferred size is auto, its minimum size is auto, and the
max track sizing function is a fixed small value. In this case, the
auto minimum size can produce a smaller track than if it was 0.

The specification needs to clarify how baseline shims interact with
minimum contributions (https://github.com/w3c/csswg-drafts/issues/3660),
but the above doesn't make sense.

BUG=934535

TEST=external/wpt/css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim.html

Change-Id: Iafd194ab7e5656b5018e0e36b915ba183bdedd19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481512
Commit-Queue: Oriol Brufau \<obrufau@igalia.com>
Reviewed-by: Manuel Rego \<rego@igalia.com>
Reviewed-by: Javier Fernandez \<jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#637299}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 3 tests and 18 subtests OK : 3 PASS : 11 FAIL : 7 New tests that have failures or other problems: /css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim-vertical-lr.html .grid 2: FAIL .grid 3: FAIL /css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim-vertical-rl.html .grid 1: FAIL .grid 2: FAIL .grid 3: FAIL /css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim.html .grid 2: FAIL .grid 3: FAIL
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/78f7e0538669 [wpt PR 15511] - [css-grid] Always consider baseline shim for the minimum contribution, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/da47f3f32c57 [wpt PR 15511] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/78f7e0538669
https://hg.mozilla.org/mozilla-central/rev/da47f3f32c57

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.