Make %AsyncFromSyncIteratorPrototype% methods return a rejected promise, not throw, when PromiseResolve throws

RESOLVED FIXED in Firefox 68

Status

()

enhancement
RESOLVED FIXED
2 months ago
10 days ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

2 months ago

:anba reported this spec bug as tc39/ecma262 issue #1461; the spec fix is PR 1470.

We need to implement that.

Assignee

Comment 1

2 months ago

The new steps are official since https://github.com/tc39/ecma262/pull/1250
landed. (Some of these step numbers change again in the next commit.)

Assignee

Comment 2

2 months ago

This makes %AsyncFromSyncIteratorPrototype%.next/return/throw return a rejected
promise, not throw, when PromiseResolve throws, following the usual convention
for methods that return promises. This follows proposed spec change
https://github.com/tc39/ecma262/pull/1470, which I expect will land with
little controversy.

Depends on D23029

Comment 4

2 months ago
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47e570e51385
Part 1: Update step numbers in comments to match current draft spec. r=anba

Comment 7

a month ago
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99a6973af7ab
Part 2: Fix error handling in %AsyncFromSyncIteratorPrototype% methods. r=anba

Comment 8

a month ago
bugherder
Status: NEW → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee

Updated

10 days ago
Flags: needinfo?(jorendorff)
You need to log in before you can comment on or make changes to this bug.