1534392 - Make %AsyncFromSyncIteratorPrototype% methods return a rejected promise, not throw, when PromiseResolve throws

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jason Orendorff [:jorendorff]]

:anba reported this spec bug as tc39/ecma262 issue #1461; the spec fix is PR 1470.

We need to implement that.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1534392 - Part 1: Update step numbers in comments to match current draft spec. r?anba

The new steps are official since https://github.com/tc39/ecma262/pull/1250
landed. (Some of these step numbers change again in the next commit.)

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1534392 - Part 2: Fix error handling in %AsyncFromSyncIteratorPrototype% methods. r?anba

This makes %AsyncFromSyncIteratorPrototype%.next/return/throw return a rejected
promise, not throw, when PromiseResolve throws, following the usual convention
for methods that return promises. This follows proposed spec change
https://github.com/tc39/ecma262/pull/1470, which I expect will land with
little controversy.

Depends on D23029

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1534392) for failing in ecma262-issue-1461.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=4c52efb1430f4b71a272998add34b63e53b00210&selectedJob=233485112

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233485112&repo=autoland&lineNumber=12023

Backout: https://hg.mozilla.org/integration/autoland/rev/00919ccaa29fbb72e5dec48903197acdb26ead0d

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47e570e51385
Part 1: Update step numbers in comments to match current draft spec. r=anba

Comment 5

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=284889277abb25bab4977e8915b0be41d7794bec

Comment 6

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba31e385b7b4d98beede20b93c951863548a1c39

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99a6973af7ab
Part 2: Fix error handling in %AsyncFromSyncIteratorPrototype% methods. r=anba

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/99a6973af7ab