1534421 - Make the CAN_RUN_SCRIPT analysis treat dereferences of pointer-typed args of CAN_RUN_SCRIPT functions as live

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

Attachment: Attempted fix.

Consider this case:

  MOZ_CAN_RUN_SCRIPT
  void foo(Arg& arg) {}

  MOZ_CAN_RUN_SCRIPT
  void bar(Arg* arg) {
    foo(*arg);
  }

ideally this would pass the analysis. Right now it doesn't, and my attempt to fix the analysis to allow it doesn't seem to work: the unaryDereferenceOperator() does match, but the hasUnaryOperand(declRefExpr()) bit does not (even if I take out the to(...) bits).

Comment 1

[Boris Zbarsky [:bzbarsky]]

I found the clang analysis docs. This all makes a lot more sense now. ;)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1534421. Fix the CAN_RUN_SCRIPT analysis to treat a deref of an arg as live if it would treat the arg as live. r=andi

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f65aaa2a97bb
Fix the CAN_RUN_SCRIPT analysis to treat a deref of an arg as live if it would treat the arg as live.  r=andi

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f65aaa2a97bb