Closed Bug 1534437 Opened 5 years ago Closed 5 years ago

Make JSFlatString::new_ always take ownership of the |chars| passed to it

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Bug 1534437 - Make JSFlatString::new_ always take ownership of the |chars| passed to it, and add the same sensible ownership handling to a bunch of callers. r=tcampbell
47 bytes, text/x-phabricator-request
Details | Review

tcampbell was complaining about the "pass in .get(), then manually .release into Unused on success" idiom ("idiom"), so he gets to review code to add UniquePtr-based handling of all this. No good deed goes Unpunished.

Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9d87882a365
Make JSFlatString::new_ always take ownership of the |chars| passed to it, and add the same sensible ownership handling to a bunch of callers.  r=tcampbell

https://hg.mozilla.org/mozilla-central/rev/b9d87882a365

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: