Closed Bug 1534437 Opened 7 months ago Closed 7 months ago

Make JSFlatString::new_ always take ownership of the |chars| passed to it

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

tcampbell was complaining about the "pass in .get(), then manually .release into Unused on success" idiom ("idiom"), so he gets to review code to add UniquePtr-based handling of all this. No good deed goes Unpunished.

Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9d87882a365
Make JSFlatString::new_ always take ownership of the |chars| passed to it, and add the same sensible ownership handling to a bunch of callers.  r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.