1534465 - Calendar menulist not initialised in event dialog

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Geoff Lankow (:darktrojan)]

Attachment: Screenshot from 2019-03-12 12-37-20.png

It looks like connectedCallback is not called on the menulist. I called it myself using the devtools and it appeared the way it should.

Comment 2

[Stefan Sitter [:ssitter]]

See Bug 1536510 for more information and regression range.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: bug1534465_calendar_menulist_init.patch

Should not go removing the menulist internals... that will mess up it's state keeping.

But any removal is not necessary, as this item is not reused so it's a once-time setup.

Comment 4

[Magnus Melin [:mkmelin]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=4a058908d612c7a03062e5c0ddf8f875d0e17dc4

Comment 5

[Magnus Melin [:mkmelin]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a91d2f87eec2d1b538b3ff87f86ba7023c43dbaa

Comment 6

[Stefan Sitter [:ssitter]]

Comment on attachment 9054149 [details] [diff] [review]
bug1534465_calendar_menulist_init.patch

Please request review from someone who is currently working on calendar code and is familiar with its techniques.

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9054149 [details] [diff] [review]
bug1534465_calendar_menulist_init.patch

That line does seem a bit pointless.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/63abcf7f08e5
Calendar menulist not initialised in event dialog. r=darktrojan

Comment 10

[Jorg K (CEST = GMT+2)]

TB 67 beta, Cal 6.9:
https://hg.mozilla.org/releases/comm-beta/rev/a8ed741351316da0077a5536dd3ab88bce52653e