Closed Bug 1534616 Opened 7 months ago Closed 7 months ago

Add mochitest for bug 1531170

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1531170 +++

Bug 1531170 fixed a hit-testing bug in WR. We should add a mochitest for it.

So I turned the reduced testcase from bug 1531170 into a mochitest. It passed on current tip, which was expected. It also passed with bug 1531170 backed out, which confused me. And I remained confused until I discovered via mozregression that Matt Woodrow snuck in a patch 8 minutes before Glenn's patch for bug 1531170 which also fixed the testcase from bug 1531170.

Matt, I thought the change you made in bug 1529458 was supposed to only be an optimization, but I guess it has a functional effect as well? Or maybe only a functional effect given the incorrect code that Glenn fixed in his patch for bug 1531170?

Flags: needinfo?(matt.woodrow)

Question is answered by bug 1534549, which indicates that yes, there is some functional effect here.

Flags: needinfo?(matt.woodrow)
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b1b462030ce
Add a mochitest for hit-testing content under a clipped modal div. r=botond
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.