Non-bypassable cert error pages should use "Advanced" instead of "More information"
Categories
(Firefox :: Security, enhancement, P3)
Tracking
()
People
(Reporter: johannh, Assigned: pong7219, Mentored)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Because the combination of "Learn more..." and "More Information" is confusing. Bypassable error pages already use "Advanced", so this shouldn't be very hard.
It comes down to removing this code: https://searchfox.org/mozilla-central/search?q=moreInformationButton&redirect=false
Reporter | ||
Comment 2•5 years ago
|
||
Hi Jawad, considering that you're assigned to so many bugs already I would recommend to take it slow and focus on the existing work. With that said, if you submit a patch for this anyway, I can assign you.
Assignee | ||
Comment 3•5 years ago
|
||
Hi Johann,
Can I work on this? The requirement is to remove the "More information" buttons and styles related to it, right?
Thanks!
Reporter | ||
Comment 4•5 years ago
|
||
Assigning to Mellina, I think Jawad has enough to do at the moment :)
Thanks!
Assignee | ||
Comment 5•5 years ago
|
||
Reporter | ||
Updated•5 years ago
|
Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38ccf27da045
Non-bypassable cert error pages should use Advanced instead of More information r=johannh
Comment 7•5 years ago
|
||
bugherder |
Reporter | ||
Comment 8•5 years ago
|
||
Comment on attachment 9050634 [details]
Bug 1534629 Non-bypassable cert error pages should use Advanced instead of More information r?johannh
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: None
- User impact if declined: Slightly inconsistent wording on cert error buttons (mostly a request from UX to have this in 67 rather than a major problem for users)
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Go to https://subdomain.preloaded-hsts.badssl.com/, the button should say "Advanced", not "More Information".
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Just deleting a few line front-end code
- String changes made/needed: None
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 9•5 years ago
|
||
Comment on attachment 9050634 [details]
Bug 1534629 Non-bypassable cert error pages should use Advanced instead of More information r?johannh
UX polish bug, low risk patch already on nightly, uplift approved for Beta 4, thanks.
Comment 10•5 years ago
|
||
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0 (20190319215514)
I managed to reproduce the issue on the older Nightly build. (20190205023948)
Verified as fixed after updating to the latest Nightly build. The issue does no longer reproduce, now the button says "Advanced" instead of "More Information"
Comment 11•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 13•5 years ago
|
||
Mozilla/5.0 (X11; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0 (20190325125126)
I managed to reproduce the issue using the Beta 67.0b3. (20190318154932)
Verified as fixed after updating to the latest Beta build (67.0b5 - 20190325125126). The issue does no longer reproduce, now the button says "Advanced" instead of "More Information"
Updated•5 years ago
|
Description
•