Update tree Custom Element to use initializeAttributeInheritance

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: bgrins, Assigned: surkov)

Tracking

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We didn't use this initially because tree uses Shadow DOM, so this querySelector wouldn't work: https://searchfox.org/mozilla-central/rev/8ff2cd0a27e3764d9540abdc5a66b2fb1e4e9644/toolkit/content/customElements.js#121. This can be fixed by first checking for shadowRoot and using it to query if it exists. This would let us simplify the attribute inheritance, similar to other elements in Bug 1527680.

Priority: -- → P3
Attachment #9051030 - Attachment is obsolete: true
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Pushed by asurkov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/787bf156ee91
make all custom elements to use the attribute inheritance base implementation, r=bgrins
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.