Closed Bug 1534714 Opened 5 years ago Closed 5 years ago

private window checkbox can still appear for themes

Categories

(WebExtensions :: General, defect, P1)

Product:
WebExtensions
Component:
General
Type:
defect

Tracking

(firefox67 verified, firefox68 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- verified
firefox68 --- verified

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1534714 handle checkbox state when appmenu refreshed across windows
47 bytes, text/x-phabricator-request
Details | Review
Bug1534714.gif
482.40 KB, image/gif
Details

This adds an onRefresh option for app menus so we can update custom controls
in any opened window. In this case, we need to refresh the checkbox state in the
addon-installed panel. We test this using the theme install test and verify both
windows do not have the checkbox.

Should try to get this in before uplift.

Priority: P2 → P1
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46e6675abc33
handle checkbox state when appmenu refreshed across windows r=Gijs

https://hg.mozilla.org/mozilla-central/rev/46e6675abc33

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Attached image Bug1534714.gif —

This issue is verified as fixed on Firefox 68.0a1 (20190320112939) and 67.0b3 (20190318154932) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.

Status: RESOLVED → VERIFIED
status-firefox67: fixed → verified
status-firefox68: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: