private window checkbox can still appear for themes

VERIFIED FIXED in Firefox 67

Status

defect
P1
normal
VERIFIED FIXED
a month ago
29 days ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

(Blocks 1 bug)

unspecified
mozilla67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 verified, firefox68 verified)

Details

Attachments

(2 attachments)

(Assignee)

Comment 1

a month ago

This adds an onRefresh option for app menus so we can update custom controls
in any opened window. In this case, we need to refresh the checkbox state in the
addon-installed panel. We test this using the theme install test and verify both
windows do not have the checkbox.

(Assignee)

Comment 2

a month ago

Should try to get this in before uplift.

Priority: P2 → P1

Comment 5

a month ago
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46e6675abc33
handle checkbox state when appmenu refreshed across windows r=Gijs

Comment 6

a month ago
bugherder
Status: NEW → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Comment 7

29 days ago
Posted image Bug1534714.gif

This issue is verified as fixed on Firefox 68.0a1 (20190320112939) and 67.0b3 (20190318154932) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.

Updated

29 days ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.