1534776 - Don't leak the world if the JS shell's main() function exits early

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Jason Orendorff [:jorendorff]]

While making some minor change recently, I found that if main() returns early for any reason, the engine complains loudly about our having leaked the world.

It's easy enough to make this never happen, just a few ScopeExits. I think.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1534776 - Don't leak the world if the shell's main() exits early. r?jwalden

This changes the order of some cleanup operations, harmlessly, to make
initialization and teardown more FIFO.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57833afcf11d
Don't leak the world if the shell's main() exits early. r=jwalden

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/57833afcf11d

Comment 4

[Jason Orendorff [:jorendorff]]

Reopening because I missed a review comment.

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1534776 - Part 2: Make a captured local variable `const`, per a review comment. r?jwalden

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0817477e4595
Part 2: Make a captured local variable `const`, per a review comment. r=jwalden

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0817477e4595