Closed Bug 1534802 Opened 7 months ago Closed 6 months ago

Remove unnecessary delegate implementations in CustomTabsActivity and WebAppActivity

Categories

(Firefox for Android :: General, enhancement, P1)

Firefox 64
enhancement

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: snorp, Assigned: snorp)

References

Details

Attachments

(1 file, 1 obsolete file)

There are a bunch of methods in there with no body, because we either don't need them or don't use them because of the "special" GV usage in Fennec. Now that we have default methods in the delegate interfaces (bug 1498721), we can remove these noop implementations.

Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/189c2c75a5ae
Remove unused GeckoView delegate overrides in Fennec r=petru
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f16aa91c7d4c
Don't enable code coverage for gradle-dependencies job r=nalexander
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Priority: -- → P1

Snorp, are you still working on this?

Sorta. I think we finally killed the jacoco stuff so this can probably land again.

Flags: needinfo?(snorp)

OK -- are you going to take that on?

Flags: needinfo?(snorp)
Attachment #9050459 - Attachment description: Bug 1534802 - Remove unused GeckoView delegate overrides in Fennec r?petru → Bug 1534802 - Remove unused GeckoView delegate overrides in Fennec
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/486ef552fa32
Remove unused GeckoView delegate overrides in Fennec r=petru
Status: REOPENED → RESOLVED
Closed: 7 months ago6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Flags: needinfo?(snorp)
Attachment #9051415 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.