Open Bug 1534836 Opened 6 years ago Updated 1 years ago

Add more options to rejected-words linter

Categories

(Developer Infrastructure :: Lint and Formatting, enhancement, P5)

enhancement

Tracking

(Not tracked)

People

(Reporter: mozbugz, Unassigned)

Details

(Keywords: good-first-bug)

To help make our source code&comments more inclusive, could reviewbot catch inappropriate words and suggest replacements?
This should catch these words not only in comments but also in identifiers.

Here's a list of suggestions intended for slackbot, maybe it could be adapted to reviewbot?
https://github.com/randsleadershipslack/documents-and-resources/blob/master/RandsInclusiveLanguage.tsv

Please check with the D&I team for a good starting list. ( https://mana.mozilla.org/wiki/display/PR/Diversity+and+Inclusion#DiversityandInclusion-OurTeam )

The priority flag is not set for this bug.
:sylvestre, could you have a look please?

Flags: needinfo?(sledru)

Maybe we could extend codespell to have this support. Either upstream or by adding a new dictionary locally.
Note that codespell is only running on files for now, not commit messages (which could be an improvement too).

Or just write some silly regexp like in https://hg.mozilla.org/mozilla-central/file/tip/tools/lint/cpp-virtual-final.yml

Severity: normal → enhancement
Component: Source Code Analysis → Lint and Formatting
Flags: needinfo?(sledru)
Keywords: good-first-bug
Priority: -- → P5
Product: Firefox Build System → Developer Infrastructure
Severity: normal → S3

We already have the rejected-words linter, so this would request would seem to fit with that.

Summary: Could reviewbot give suggestions about more inclusive language? → Add more options to rejected-words linter
You need to log in before you can comment on or make changes to this bug.