Assertion failure: !canNotPlacePool_, at js/src/jit/shared/IonAssemblerBufferWithConstantPools.h:971
Categories
(Core :: JavaScript Engine, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox66 | --- | disabled |
| firefox67 | --- | wontfix |
| firefox68 | --- | fixed |
People
(Reporter: gkw, Assigned: nbp)
References
(Blocks 1 open bug)
Details
(4 keywords, Whiteboard: [jsbugmon:])
Attachments
(2 files, 4 external files, 1 obsolete file)
The following testcase crashes on mozilla-central revision c89f024c023f (build with --enable-debug --disable-profiling --enable-more-deterministic --enable-simulator=arm64 and with Asan, run with --fuzzing-safe --wasm-compiler=none --wasm-gc --test-wasm-await-tier2 --ion-scalar-replacement=on --ion-edgecase-analysis=off --ion-eager --more-compartments --cpu-count=7 --gc-zeal=0,34 --no-incremental-gc --no-threads --baseline-eager):
See attachment.
See backtrace for Asan stack.
For detailed crash information, see attachment.
This is a hard-to-reproduce issue, but since there is an Asan stack, I hope this is useful. This should be related to IonMonkey on ARM64.
| Reporter | ||
Comment 1•7 years ago
|
||
| Reporter | ||
Comment 2•7 years ago
|
||
| Reporter | ||
Updated•7 years ago
|
Comment 4•7 years ago
|
||
This is a JS fuzzing bug and sdetar said the team will fix as many as they can in 67 but will not be able to get to all. Marking them fix-optional.
Updated•7 years ago
|
Comment 5•7 years ago
|
||
Setting as P2 -- this type of crash is difficult to reproduce, but it occurs in TableSwitch and we ought to fix it by convincing ourselves of that code's safety.
| Assignee | ||
Comment 6•7 years ago
|
||
So far I did not manage to reproduce the original issue, but I spawn it under rr and I will let it run for a few hours see if it catches anything.
I will try to proof read this code in the mean time.
| Assignee | ||
Comment 7•7 years ago
|
||
(In reply to Nicolas B. Pierron [:nbp] from comment #6)
[…] I spawn it under rr and I will let it run for a few hours see if it catches anything.
Letting it run over night is unsuccessful so far.
| Assignee | ||
Comment 8•7 years ago
|
||
(In reply to Sean Stangl [:sstangl] from comment #5)
Setting as P2 -- this type of crash is difficult to reproduce, but it occurs in TableSwitch and we ought to fix it by convincing ourselves of that code's safety.
My biggest concern with this code is that fact that EmitData is being called for each pointer to be added as part of the jump table. I am tempted to clean-up this code to have a writeJumpTable function which would create a CodeLabelArray and call EmitData only once.
| Assignee | ||
Comment 9•7 years ago
|
||
| Assignee | ||
Comment 10•7 years ago
|
||
The previous patch is way too complicated, even if it would be nicer at the end but might have issues with very large jump-tables, there is zero chances to get it backported. I uploaded it for posterity.
I am investigating a simpler way … consisting of adding more assertions.
| Assignee | ||
Comment 11•7 years ago
|
||
| Assignee | ||
Comment 12•7 years ago
|
||
Depends on D26520
| Assignee | ||
Comment 13•7 years ago
|
||
Depends on D26521
| Assignee | ||
Comment 14•7 years ago
|
||
Depends on D26522
Updated•7 years ago
|
Comment 15•7 years ago
|
||
Comment 16•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/639d0d388b96
https://hg.mozilla.org/mozilla-central/rev/4f54d68ba18e
https://hg.mozilla.org/mozilla-central/rev/e024cb135284
https://hg.mozilla.org/mozilla-central/rev/e55ace0633da
Updated•7 years ago
|
Description
•