Editor may get stuck showing "Loading..."
Categories
(DevTools :: Debugger, enhancement, P1)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: loganfsmyth, Assigned: loganfsmyth)
Details
Attachments
(3 files)
Reported originally in https://github.com/firefox-devtools/debugger/issues/8106
It looks like loadSourceText can get into an unexpected state if the page refreshes while loading.
|
Assignee | |
Comment 1•5 years ago
|
||
Splitting up this logic makes us less likely to introduce code that would break
the caching behavior. If you look closely at these changes, you'll notice that
there actually one one early return in this code that would cause us to
exit without clearing the 'requests' cache meaning we could get stuck in
an infinite loading state.
|
|
Assignee | |
Comment 2•5 years ago
|
||
If users navigate while source text is loading, we need to ignore existing
cached promises because they may resolve and then not actually set the
resulting source, because the source was deleted from the source list.
We want to explicitly use a new cache entry if we have navigated.
Depends on D23451
|
|
Assignee | |
Comment 3•5 years ago
|
||
Returning null here leaves us in an infinite loading state because null is treated as neither
success nor failure.
Depends on D23452
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7cf6462189e8 Part 1: Refactor loadSourceText to separate caching from logic. r=jlast https://hg.mozilla.org/integration/autoland/rev/27a3400989c9 Part 2: Invalidate the loadSourceText cache on navigation. r=jlast https://hg.mozilla.org/integration/autoland/rev/ee3da1413835 Part 3: Pass originalText load failure through to UI instead of failing silently.
|
||
Comment 7•5 years ago
|
||
Backed out for failing debugger
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233996724&repo=autoland&lineNumber=639
Backout: https://hg.mozilla.org/integration/autoland/rev/fa6af8c14ee45a20df4c3f83286b85874082f877
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3befa22661a8 Part 1: Refactor loadSourceText to separate caching from logic. r=jlast https://hg.mozilla.org/integration/mozilla-inbound/rev/35af4e6b5633 Part 2: Invalidate the loadSourceText cache on navigation. r=jlast https://hg.mozilla.org/integration/mozilla-inbound/rev/f3500b0a2f3b Part 3: Pass originalText load failure through to UI instead of failing silently. r=jlast
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3befa22661a8
https://hg.mozilla.org/mozilla-central/rev/35af4e6b5633
https://hg.mozilla.org/mozilla-central/rev/f3500b0a2f3b
|
|
Assignee | |
Updated•5 years ago
|
Description
•