1534896 - Don't close the login autocomplete popup when the search string becomes empty

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement, P2)

Description

[Matthew N. [:MattN]]

Since the initial landing of satchel/autocomplete, when the field text becomes empty, the popup closes, even if there are relevant results to show. This may make sense for the awesomebar(?) but it doesn't make sense as much sense for logins fields where the initial value may have been populated from the site and the user could greatly benefit from login suggestions immediately after clearing the field.

The two main cases when showing the popup upon clearing the field value:

• Show the full list of logins available to fill (or the View Saved Logins footer)
• Showing the insecure login field warning

It seems like Chrome and Safari only have this behaviour for login fields, not <input list="…"> or for address autofill so we should probably do the same. We should also leave the address bar behaviour alone so we should probably add an attribute on nsIAutoCompleteInput to control this. nsFormFillController can then return a boolean depending on whether the focused field is marked as a login field: mPwmgrInputs.Get(…).

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1534896 - Don't close the login autocomplete popup when the search string becomes empty. r=jaws,mak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54ae8fe6502b
Don't close the login autocomplete popup when the search string becomes empty. r=jaws

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/54ae8fe6502b

Comment 4

[Adrian Florinescu [:aflorinescu]]

Matt, could you confirm that the change here to verify is that the saved logins pop-up remains open after the text clear of the field? Does this apply to insecure scenario, as well?

Comment 5

[Matthew N. [:MattN]]

(In reply to Adrian Florinescu [:adrian_sv] from comment #4)

Matt, could you confirm that the change here to verify is that the saved logins pop-up remains open after the text clear of the field?

Yes

Does this apply to insecure scenario, as well?

Yes, I believe it should.

Comment 6

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on Nightly 68.0a1 / 2019-03-28 Mac 10.13, Windows 10, Ubuntu 16.04.

Also checked on 67.0b5 2019-03-25 Win 10/Ubuntu 16.04 turning "signon.showAutoCompleteFooter" pref. on, the behavior is as expected.

The above applies for both the secure and insecure scenarios.