1534913 - Port "Bug 1521280 - Remove search-textbox binding" to Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1521280 +++

Bug 1521280 will remove the support for <textbox type="search">.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1534913_search-textbox-port.patch

This should be it. It's apparently not working completely, but I think bug 1534930 could solve it. The m-c patch is also not 100% done yet so perhaps some moving parts from there too.

Comment 2

[Magnus Melin [:mkmelin]]

Just for reference, in the preferences(?) I got

console.error: (new TypeError("setting getter-only property "inputField"", "chrome://global/content/elements/search-textbox.js", 62))
console.error: (new TypeError("setting getter-only property "inputField"", "chrome://global/content/elements/search-textbox.js", 62))
prpl-irc: Unused mode parameters: #test
JavaScript error: chrome://global/content/bindings/textbox.xml, line 239: TypeError: this.setSelectionRange is not a function
JavaScript error: chrome://global/content/bindings/textbox.xml, line 247: TypeError: this._maybeSelectAll is not a function
JavaScript error: chrome://global/content/bindings/textbox.xml, line 247: TypeError: this._maybeSelectAll is not a function
JavaScript error: chrome://global/content/bindings/textbox.xml, line 239: TypeError: this.setSelectionRange is not a function
JavaScript error: chrome://global/content/bindings/textbox.xml, line 247: TypeError: this._maybeSelectAll is not a function

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug_1534913___Port__Bug_1521280___Remove_search_textbox_binding__to_Thunderbird__r_.patch

Bug 1521280 will land in the next days.
This seems to work fine.

I do get an error about gApplicationsPane.rebuildView "is not a function", but that happens on trunk too (for the applications search)
https://searchfox.org/comm-central/rev/b2c998eb41d696d31a87384487514e9b386f201c/mail/components/preferences/applications.inc.xul#49

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9058957 [details] [diff] [review]
Bug_1534913___Port__Bug_1521280___Remove_search_textbox_binding__to_Thunderbird__r_.patch

Looks OK.

Comment 5

[Jorg K (CEST = GMT+2)]

When bug 1521280 gets merged.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/55a635377bed
Port bug 1521280 [Remove search-textbox binding] to Thunderbird. r=jorgk

Comment 7

[Jorg K (CEST = GMT+2)]

Look like you need to fix two tests now:
TEST-UNEXPECTED-FAIL | Z:\task_1557525750\build\tests\mozmill\quick-filter-bar\test-keyboard-interface.js | test-keyboard-interface.js::test_control_shift_k_shows_quick_filter_bar
EXCEPTION: second control-shift-k did not select text in filter textbox

TEST-UNEXPECTED-FAIL | Z:\task_1557525750\build\tests\mozmill\testLocalICS.js | testLocalICS.js::testLocalICS
EXCEPTION: Expression "{"anonid":"moz-input-box"}" returned null. Anonymous == true
EXCEPTION: menuitem is null

Maybe the Calendar failure is unrelated?

Comment 8

[Geoff Lankow (:darktrojan)]

The calendar failure appears to be related. The element in question is a <textbox type="search">.

Comment 9

[Jorg K (CEST = GMT+2)]

You should have told me which one, since it seems that Magnus replaced the three I can see:

calendar/base/content/calendar-task-view.xul
48 type="search"
calendar/base/content/calendar-unifinder.xul
55 type="search"
calendar/resources/content/calendarCreation.xul
62 type="search"

EDIT: OK, so you're saying that element needs further code adjustments. We might find an example here:
https://hg.mozilla.org/mozilla-central/rev/c5798de806e2

Comment 10

[Geoff Lankow (:darktrojan)]

No, I'm saying the test looking for anonymous content inside a search box needs adjusting.

https://searchfox.org/comm-central/rev/a653b89e3b20b60cfab618a2798d5af12973735f/calendar/test/mozmill/shared-modules/test-calendar-utils.js#543

Comment 11

[Jorg K (CEST = GMT+2)]

Yes, I got there too looking for "anonid":"moz-input-box". Sadly this magic needs another sorcerer :-(

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fc51c0e147cc
temporarily disable failining tests. rs=bustage-fix DONTBUILD

Comment 13

[Magnus Melin [:mkmelin]]

Attachment: bug1534913_input_search_tests.patch

Fix the tests. Sent to try now: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8c205f309e6a2244da18ea8fa187aee5833b3ad1

Comment 14

[Jorg K (CEST = GMT+2)]

Thanks. Linux debug is not the best choice for a try since it has some many oranges. Let's try Mac instead:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=271ed605f84624b02a5fed25339f893f6d0c7ac6

I tried adding .inputField like in https://hg.mozilla.org/mozilla-central/rev/c5798de806e2#l26.19, but I added it to the wrong spot. Seems so obvious now :-(

EDIT: I wonder whether -u mozmill will work at all. I think only -u all works these days due to the "1proc" suffixes.

Comment 15

[Jorg K (CEST = GMT+2)]

Comment on attachment 9064309 [details] [diff] [review]
bug1534913_input_search_tests.patch

Thanks. My try was successful, yours didn't go anywhere.

Comment 16

[Magnus Melin [:mkmelin]]

Yeah typoed, was supposed to be the opt build.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b38b8ba2148b
Follow-up: test fixes. r=jorgk

Comment 18

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/937e7c60b40043bbdd456e18aaef5df8c0af91a1
Backed out 3 changesets (bug 1534913) since ported bug 1521280 was backed out. a=backout

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/779732045e34
Port bug 1521280 [Remove search-textbox binding] to Thunderbird. r=jorgk