1534927 - warningGroup message should be created outside of console.group

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

So, let's say you do the following:

1. execute console.groupCollapsed("action")
2. Do some action in the page, at least on that can lead to a content blocked warning messages
3. execute console.groupEnd()
4. Do other actions in the page that can lead to content blocked warning messages.

With Bug 1524276 the tracking protection messages are going to be grouped, but since we show the group at the position of the first tracking protection message, in our case we won't see that there are new warning messages (because the console.groupCollapsed is closed).

To prevent this, we should create warningGroups before the outermost current console.group.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1534927 - Create warningGroup outside of console.group. r=Honza.

With this patch, we always create warningGroups outside of the outermost
console.group the first warning message could be in.
This is done because we don't want a warningGroup to be burried in a console.group,
or worse, in a console.groupCollapsed, where it wouldn't be visible at all.

The messages reducer is modified to do that, and a test is added
to ensure all the group interactions work as expected.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/354e9abf1a43
Create warningGroup outside of console.group. r=Honza.

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/354e9abf1a43