warningGroup message should be created outside of console.group

RESOLVED FIXED in Firefox 68

Status

enhancement
P1
normal
RESOLVED FIXED
3 months ago
Last month

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Tracking

66 Branch
Firefox 68
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: [console-grouping])

Attachments

(1 attachment)

Assignee

Description

3 months ago

So, let's say you do the following:

  1. execute console.groupCollapsed("action")
  2. Do some action in the page, at least on that can lead to a content blocked warning messages
  3. execute console.groupEnd()
  4. Do other actions in the page that can lead to content blocked warning messages.

With Bug 1524276 the tracking protection messages are going to be grouped, but since we show the group at the position of the first tracking protection message, in our case we won't see that there are new warning messages (because the console.groupCollapsed is closed).

To prevent this, we should create warningGroups before the outermost current console.group.

Assignee

Updated

3 months ago
Whiteboard: [console-group]
Assignee

Updated

3 months ago
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Assignee

Comment 1

3 months ago

With this patch, we always create warningGroups outside of the outermost
console.group the first warning message could be in.
This is done because we don't want a warningGroup to be burried in a console.group,
or worse, in a console.groupCollapsed, where it wouldn't be visible at all.

The messages reducer is modified to do that, and a test is added
to ensure all the group interactions work as expected.

Comment 2

3 months ago
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/354e9abf1a43
Create warningGroup outside of console.group. r=Honza.

Comment 3

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Whiteboard: [console-group] → [console-grouping]
You need to log in before you can comment on or make changes to this bug.