Open Bug 1534966 Opened 5 years ago Updated 2 years ago

Consider removing AutoObjectVectorWrapper from the rust bindings

Categories

(Core :: JavaScript: GC, enhancement, P3)

Product:
Core
Component:
JavaScript: GC
Type:
enhancement

Tracking

()

People

(Reporter: allstars.chh, Unassigned)

References

Details

In Bug 1521732 we will replace AutoObjectVector with RootedObjectVector, however in https://searchfox.org/mozilla-central/rev/89414a1df52d06cfc35529afb9a5a8542a6e4270/js/rust/src/jsglue.cpp#557

JS::AutoObjectVector* vec = new JS::AutoObjectVector(aCx);

it's going to be like
JS::RootedObjectVector* vec = new JS::RootedObjectVector(aCx);

which looks weird, as sfink suggests, we should file a bug for considering removing this.
see https://phabricator.services.mozilla.com/D23187#inline-134487

This kind of use should use PersistentRooted<> rather than Rooted<>.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.