1534990 - Two telemetry pings are displayed in the browser console if a tab is pinned from the "CFR Pin Tabs" doorhanger

Status: RESOLVED INVALID

(Firefox :: Messaging System, defect)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Nightly 67.0a1, Build ID 20190313100914

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have a Firefox profile with the following pref in the "about:config" page:
  • "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" set to "true";
  • "browser.ping-centre.log" set to "true";
• Have the browser console opened.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to the "about:newtab#asrouter" page and scroll down to the "PIN_TAB" section.
3. Click the section's "Show" button and click the "CFR Recommendation" button from the right part of the "Address Bar".
4. Click the doorhanger's "Pin This Tab" button.
5. Focus the "Browser Console" and observe the displayed pings.

[Expected result]:

• Only one telemetry ping is displayed for the PIN event:

"TELEMETRY PING: {"locale":"en-US","topic":"activity-stream-router","client_id":"35530052-ce26-804b-a374-2c430640f86a","version":"67.0a1","release_channel":"nightly","addon_version":"20190313100914","impression_id":"n/a","action":"cfr_user_event","source":"CFR","message_id":"PIN_TAB","event":"PIN","profile_creation_date":17968,"region":"RO"}".

[Actual result]:

• Two telemetry pings are displayed for the PIN event:

TELEMETRY PING: {"locale":"en-US","topic":"activity-stream","client_id":"35530052-ce26-804b-a374-2c430640f86a","version":"67.0a1","release_channel":"nightly","addon_version":"20190313100914","user_prefs":251,"action":"activity_stream_user_event","event":"TABPINNED","value":{"total_pinned_tabs":1},"source":"TAB_CONTEXT_MENU","page":"n/a","session_id":"n/a","profile_creation_date":17968,"region":"RO"}

TELEMETRY PING: {"locale":"en-US","topic":"activity-stream-router","client_id":"35530052-ce26-804b-a374-2c430640f86a","version":"67.0a1","release_channel":"nightly","addon_version":"20190313100914","impression_id":"n/a","action":"cfr_user_event","source":"CFR","message_id":"PIN_TAB","event":"PIN","profile_creation_date":17968,"region":"RO"}

[Notes]:

• Our main concern is that we could create confusion in reading/analyzing metrics as it looks like the doorhanger also sends the same ping as the regular pin action.
• Attached a screen recording of the issue.

Comment 1

[Andrei Oprea [:andreio]]

This is expected:

• one ping lets us know the user took the primary action of the CFR message
• other message is telling us a tab was pinned