1535016 - adjust android pageload to run every 5th push by hacking SETA to not treat them as new jobs

Status: RESOLVED FIXED

Description

[Joel Maher ( :jmaher ) (UTC-4)]

we currently determine if a task is high value (per commit) or low value (every 5th commit) via this logic:
https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/util/seta.py#56

seta by default (inside of treeherder) treats new jobs as new and doesn't call them low value until 2 weeks of time has elapsed.

I recommend a shortcut in the taskcluster code so we can treat all android raptor tp6 jobs as low value, that should significantly reduce the load.

Comment 1

[Joel Maher ( :jmaher ) (UTC-4)]

:davehunt, I don't have time today for this, happy to look into it later this week- this might be something to look at on your team especially as you are adding new jobs frequently.

I know :ahal has some tricks for dumping the taskgraph before/after a change, I assume we can test this prior to landing

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚️UTC]

:igoldan could you take a look into this? Our tp6m tests are saturating our devices, and this should help to take some pressure off.

Comment 3

[Ionuț Goldan [:igoldan], Performance Sheriffing]

(In reply to Dave Hunt [:davehunt] [he/him] ⌚️UTC from comment #2)

:igoldan could you take a look into this? Our tp6m tests are saturating our devices, and this should help to take some pressure off.

Yes, I can.

Comment 4

[Ionuț Goldan [:igoldan], Performance Sheriffing]

Attachment: Bug 1535016 - Don't treat any Android job as new job

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ce6dd37ff59
Don't treat any Android job as new job r=jmaher

Comment 6

[Arthur Iakab [arthur_iakab]]

Backed out changeset 2ce6dd37ff59 (bug 1535016) for mozlint failure on taskcluster/taskgraph/util/seta.py CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/de3d7088cbc525899978e666803ed7faa931f485

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=2ce6dd37ff59bde0d00cbddf18426b49b39df4d4&searchStr=linting%2Copt%2Csource-test-mozlint-py-flake8%2C%28f8%29

Log failure https://treeherder.mozilla.org/logviewer.html#?job_id=234159884&repo=autoland

Igoldan: could you please take a look?

Comment 7

[Ionuț Goldan [:igoldan], Performance Sheriffing]

(In reply to Arthur Iakab [arthur_iakab] from comment #6)

Igoldan: could you please take a look?

Thanks Arthur for doing the backout!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/551c42866143
Don't treat any Android job as new job r=jmaher

Comment 9

[Raul Gurzau (:RaulGurzau)]

https://hg.mozilla.org/mozilla-central/rev/551c42866143