Closed Bug 1535044 Opened 7 months ago Closed 7 months ago

Missing mozilla namespace in TestGroupId.cpp

Categories

(Core :: WebRTC: Audio/Video, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

Details

Attachments

(1 file)

TestGroupId.cpp cannot be built when adding a new gtest file into dom/media/gtest. From the log(below), it seems to me that mozilla namespace should be introduced into TestGroupId.cpp

...
...
3:58.59 /<path>/<to>/gecko/dom/media/gtest/TestGroupId.cpp:26:38: error: unknown class name 'MediaEngineSource'; did you mean 'mozilla::MediaEngineSource'?
 3:58.59 class MockMediaEngineSource : public MediaEngineSource {
 3:58.59                                      ^~~~~~~~~~~~~~~~~
 3:58.59                                      mozilla::MediaEngineSource
 3:58.59 /<path>/<to>/gecko/dom/media/webrtc/MediaEngineSource.h:283:7: note: 'mozilla::MediaEngineSource' declared here
 3:58.59 class MediaEngineSource : public MediaEngineSourceInterface {
 3:58.59       ^
 3:58.63 In file included from /<path>/<to>/gecko/obj-x86_64-pc-linux-gnu/dom/media/gtest/Unified_cpp_dom_media_gtest1.cpp:2:
 3:58.63 /<path>/<to>/gecko/dom/media/gtest/TestGroupId.cpp:28:38: error: use of undeclared identifier 'dom'; did you mean 'mozilla::dom'?
 3:58.63   MOCK_CONST_METHOD0(GetMediaSource, dom::MediaSourceEnum());
 3:58.63                                      ^~~
 3:58.63                                      mozilla::dom
...
...
Assignee: nobody → cchang
Blocks: 1213453, 1500713
Rank: 15
Priority: -- → P2
Keywords: checkin-needed

Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f04779216e2b
Introduce mozilla namespace in TestGroupId.cpp. r=pehrsons

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.