Closed
Bug 1535063
Opened 5 years ago
Closed 5 years ago
Updated how scrolling into view works for items inside VirtualizedTree.
Categories
(DevTools :: Shared Components, enhancement)
DevTools
Shared Components
Tracking
(firefox68 fixed)
RESOLVED
FIXED
Firefox 68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: yzen, Assigned: yzen)
Details
Attachments
(2 files)
Right now scrolling into view is broken for items inside virtualized tree that are part of the traversal but are not rendered (e.g. scrolled out). This needs to be fixed using the information that we already have - height of the tree item + item index.
Additionally I would like to add another prop for the virtualized tree tentatively called "shown" that takes a item rendered as one of the tree items that we want to be rendered and shown in the tree. Use case of that is row "highlighting" that is often implemented by trees like markup tree or a11y tree.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D23357
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/800db0f24068 fix scrolling into view for VirtualizedTree items that are part of the traversal but not rendered. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/ba5b19667e2c add shown property to VirtualizedTree component that defines a tree item to be rendered and shown within the tree. r=nchevobbe
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/800db0f24068
https://hg.mozilla.org/mozilla-central/rev/ba5b19667e2c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in
before you can comment on or make changes to this bug.
Description
•