1535063 - Updated how scrolling into view works for items inside VirtualizedTree.

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Right now scrolling into view is broken for items inside virtualized tree that are part of the traversal but are not rendered (e.g. scrolled out). This needs to be fixed using the information that we already have - height of the tree item + item index.

Additionally I would like to add another prop for the virtualized tree tentatively called "shown" that takes a item rendered as one of the tree items that we want to be rendered and shown in the tree. Use case of that is row "highlighting" that is often implemented by trees like markup tree or a11y tree.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1535063 - fix scrolling into view for VirtualizedTree items that are part of the traversal but not rendered. r=nchevobbe

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1535063 - add shown property to VirtualizedTree component that defines a tree item to be rendered and shown within the tree. r=nchevobbe

Depends on D23357

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/800db0f24068
fix scrolling into view for VirtualizedTree items that are part of the traversal but not rendered. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/ba5b19667e2c
add shown property to VirtualizedTree component that defines a tree item to be rendered and shown within the tree. r=nchevobbe

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/800db0f24068
https://hg.mozilla.org/mozilla-central/rev/ba5b19667e2c