Closed Bug 1535077 Opened 5 years ago Closed 5 years ago

Switch to using Ref and PureComponent in the SearchBox component

Categories

(DevTools :: Shared Components, enhancement, P3)

Product:
DevTools
Component:
Shared Components
Type:
enhancement

Tracking

(firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: gl, Assigned: gl)

Details

Attachments

(1 file)

Bug 1535077 - Switch to using Ref and PureComponent in the SearchBox component. r=Honza
47 bytes, text/x-phabricator-request
Details | Review
  • Switch to using PureComponent
  • Switch to using React Refs
  • Added a lazy getter for AutocompletePopup and KeyShortcuts
  • Added isRequired for all the required props
  • Sorted the props since that seemed to be the original pattern in this component
  • Removed divClassList since the class list doesn't mutate.
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/abe66ccddd97
Switch to using Ref and PureComponent in the SearchBox component. r=Honza

https://hg.mozilla.org/mozilla-central/rev/abe66ccddd97

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: