1535119 - updateTitle called too often when selecting a conversation that has not been displayed yet and has unread messages

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, enhancement)

Description

[Florian Quèze [:florian]]

See https://perfht.ml/2UBs3XM (I selected #developers where I had ~500 unread messages).

For each message we display, we call updateTitle, which iterates over all the conversations.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1535119 - avoid updating the title once per message when displaying a conversation with unread messages for the first time, r=clokep.

Comment 2

[Jorg K (CEST = GMT+2)]

Was this meant to be landed?

Comment 3

[Patrick Cloke [:clokep]]

Hmm...I think it was meant to, it is completely bitrotted now though (since this is now a custom element, not a binding). Florian -- do you know if there was any reason NOT to land this?

Comment 4

[Patrick Cloke [:clokep]]

Attachment: Rebased patch after change to custom component + eslint

Florian, any reason we can't land this? I tested it briefly and it seems to work OK.

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 9113297 [details] [diff] [review]
Rebased patch after change to custom component + eslint

Review of attachment 9113297 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, let's just land this. I wanted to do more testing at the time to ensure I wasn't regressing anything, but I don't think I'll get to it anytime soon, and we already have worse regressions to track than what edge cases in this patch might cause.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2cfb1d544ba0
avoid updating the title once per message when displaying a conversation with unread messages for the first time, r=clokep.