Closed
Bug 1535119
Opened 5 years ago
Closed 4 years ago
updateTitle called too often when selecting a conversation that has not been displayed yet and has unread messages
Categories
(Thunderbird :: Instant Messaging, enhancement)
Thunderbird
Instant Messaging
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 73.0
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(2 files)
See https://perfht.ml/2UBs3XM (I selected #developers where I had ~500 unread messages).
For each message we display, we call updateTitle, which iterates over all the conversations.
Assignee | ||
Comment 1•5 years ago
|
||
Comment 2•5 years ago
|
||
Was this meant to be landed?
Flags: needinfo?(florian)
Flags: needinfo?(clokep)
Comment 3•5 years ago
|
||
Hmm...I think it was meant to, it is completely bitrotted now though (since this is now a custom element, not a binding). Florian -- do you know if there was any reason NOT to land this?
Comment 4•4 years ago
|
||
Florian, any reason we can't land this? I tested it briefly and it seems to work OK.
Flags: needinfo?(clokep)
Attachment #9113297 -
Flags: review?(florian)
Assignee | ||
Comment 5•4 years ago
|
||
Comment on attachment 9113297 [details] [diff] [review] Rebased patch after change to custom component + eslint Review of attachment 9113297 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, let's just land this. I wanted to do more testing at the time to ensure I wasn't regressing anything, but I don't think I'll get to it anytime soon, and we already have worse regressions to track than what edge cases in this patch might cause.
Attachment #9113297 -
Flags: review?(florian) → review+
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(florian)
Updated•4 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed-tb
Pushed by clokep@gmail.com:
https://hg.mozilla.org/comm-central/rev/2cfb1d544ba0
avoid updating the title once per message when displaying a conversation with unread messages for the first time, r=clokep.
Updated•4 years ago
|
Target Milestone: --- → Thunderbird 73.0
You need to log in
before you can comment on or make changes to this bug.
Description
•