Closed Bug 1535151 Opened 6 years ago Closed 6 years ago

Clarify argument to CCCrypt in KeyBundle.swift

Categories

(Firefox for iOS :: Sync, enhancement, P3)

Product:
Firefox for iOS
Component:
Sync
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: justindarc, Assigned: justindarc)

Details

Need to add a comment here that kCCAlgorithmAES128 is the block size, not the key size:

https://github.com/mozilla-mobile/firefox-ios/blob/4c3bd2cb7fc281ccd1da80398fab5657aafb0a13/Account/KeyBundle.swift#L116

Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
tracking-fxios: ? → +
Priority: -- → P3

Also it should be using CCAlgorithm rather than CCHmacAlgorithm, because it's doing encryption rather than HMAC.

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/0cfd957a95c082eed1335b9017c8d91e97ccb3cf

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.