Closed Bug 1535182 Opened 7 months ago Closed 7 months ago

Export BaseControlMixin and MozElementMixin through MozElements instead of directly on window

Categories

(Toolkit :: XUL Widgets, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bgrins, Assigned: aswan)

References

Details

Attachments

(1 file)

This is just a code cleanup - these two classes were attached onto the window before we had MozElements and never got updated: https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/toolkit/content/customElements.js#492-493.

Mentor: bgrinstead
Keywords: good-first-bug
Priority: -- → P5

These references should change from MozElementMixin to MozElements.MozElementMixin:

https://searchfox.org/mozilla-central/search?q=MozElementMixin&path=

And these references should change from BaseControlMixin to MozElements.BaseControlMixin:

https://searchfox.org/mozilla-central/search?q=BaseControlMixin&path=

Assignee: nobody → aswan
Mentor: bgrinstead
Keywords: good-first-bug

There's a lot of orange here but they all look like known intermittents:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a5604a37e03d93bae4c692748f1f32138bd1ec2

Blocks: 1539093
Attachment #9053471 - Attachment description: Bug 1535182 Remove BaseElementMixin and MozElementMixwin from window global r=bgrins → Bug 1535182 Remove BaseElementMixin and MozElementMixin from window global r=bgrins
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/912818869def
Remove BaseElementMixin and MozElementMixin from window global r=bgrins
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.