1535204 - Modal dialog on tab-close does not clearly indicate active-inactive button states

Status: REOPENED

(Core :: Widget: Cocoa, defect, P3)

Description

[:Atoll]

Attachment: Screen Shot 2019-03-13 at 18.13.57.png

On macOS latest and Nightly 2019-03-11, the attached modal dialog thrown by Firefox when I tried to close a tab contains two buttons.

Which button will activate when I press return — the brighter one, or the shadow-ier one?

Using a shade of gray for the primary button, that is only slightly differentiated from the non-default buttons, violates various HID guidelines, including Firefox's (Photon) and Apple's (macOS):

Behaviours — Primary — Behaviour styles such as hover, pressed and focus of a primary button:
Default Background: Blue 60 #0060df

— https://design.firefox.com/photon/components/buttons.html

A default push button is prominent in appearance and automatically performs its action when the user presses Return.

— https://developer.apple.com/design/human-interface-guidelines/macos/buttons/push-buttons/

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

This looks a UI design/front-end issue, which is not "user events and focus handling" problem.
I have no idea which module fits well, but guess should be one under Firefox product.

Comment 2

[Liviu Seplecan]

I've tested this issue on several machines Windows 10, Mac OS X and Ubuntu 16.04. On Ubuntu & Mac OS X the issue can be reproduced as presented in the description.

1. In windows 10, on Firefox versions the modal dialog triggered has a different appearance, it can be observed that the "Leave Page" button has blue borders - due the fact that the previous option (invoking the leaving from that page). I guess this is a properly aspects of this modal dialog to appear.
2. In Ubuntu this modal looks more confusing, both buttons have the same appearance even at hover-over action. I will attach screenshots to see the differences.
3. In Mac OS X on all Firefox versions the modal dialog appears as in the screenshot posted by @:Atoll

@Hsin-Yi Tsai I will set a component to this issue and if isn't an appropriate one please feel free to change it.

Comment 3

[:Atoll]

Since this issue affects multiple platforms and is not tagged macOS specifically, could someone from Firefox team please help me ensure this bug gets cloned/moved/etc. appropriately to help Ubuntu users as well?

Comment 4

[Liviu Seplecan]

Attachment: Screenshot bug -1535204- Ubuntu.png

Comment 5

[Liviu Seplecan]

Attachment: screenshot bug 1535204 - windows 10.png