1535242 - Provide better message when choosing a directory to clone.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P5)

Description

[Tooru Fujisawa [:arai]]

While running bootstrap.py outside the repository, it offers cloning.

If you would like to clone the mozilla-unified Mercurial repository, please
enter the destination path below.

Destination directory for Mercurial clone (leave empty to not clone): /tmp/non-empty
ERROR! Destination directory '/tmp/non-empty' is not empty.

Would you like to clone to '/tmp/non-empty/mozilla-unified'?

  1. Yes
  2. No, let me enter another path
  3. No, stop cloning

Please enter your reply: 2
Destination directory for Mercurial clone (leave empty to not clone): /tmp/contains-with-mozilla-unified

ERROR! Destination directory '/tmp/contains-with-mozilla-unified' is not empty.

I got feedback about the first ERROR! that it doesn't sounds like error but warning.
surely, it's most likely a not erroneous case but just that the user supposed that the question is about the directory where the mozilla-unified subdirectory is created.
so it's better using WARNING, or just omit it.

Then also the 2nd case doesn't say what the issue is.
it should say that mozilla-unified exists there.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1535242 - Provide better message when choosing a directory to clone. r?glandium

• Do not use ERROR when user enters possibly parent-directory when
  choosing the directory to clone mozilla-unified
• Show the path of pre-existing mozilla-unified path on error

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f7dde1eb085
Provide better message when choosing a directory to clone. r=glandium

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/8f7dde1eb085