Closed Bug 1535263 Opened 9 months ago Closed 9 months ago

Quantumbar: Move role="combobox" from the input field to a parent node

Categories

(Firefox :: Address Bar, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

From https://phabricator.services.mozilla.com/D23155#inline-135750:

I think the role="combobox" needs to go from the input to a parent like in the W3C examples. I played with this in a current Nightly, and I get very inconsistent results when typing in text. The input should announce itself to the screen reader as a text input like in the old awesome bar.

I was wondering if role="combobox" should move to a parent, but wasn't sure because the div doesn't seem to serve any other function in the w3c example and it's unclear what it's good for. I'm now guessing it's needed because otherwise role="combobox" overrides the input's default implied role.

(In reply to Dão Gottwald [::dao] from comment #0)

I was wondering if role="combobox" should move to a parent, but wasn't sure because the div doesn't seem to serve any other function in the w3c example and it's unclear what it's good for. I'm now guessing it's needed because otherwise role="combobox" overrides the input's default implied role.

Right, the ARIA role always takes precedence, even on native HTML elements that are widgets. So we have to be careful. Like I said, since I wasn't sure myself, we might need to iterate until we get this right.

There is currently also still another problem that is possibly for a different bug, and that is that the list opens and gains focus the moment I type something in. In the old URL bar, I have to explicitly press DownArrow for the first element to have its activedescendant set, otherwise I could not use the left and right arrow keys to read what I typed. But that might be for a different bug. This is one of the things Jamie Teh finally did right last year when he also introduced the URLbar tests.

Comment on attachment 9050935 [details]
Bug 1535263 - Move role=combobox from the input field to a parent node.

Moving role and aria-owns seems to break cycling through the results -- NVDA announces "Unknown" instead of the result labels. Any clue why that's the case?

Attachment #9050935 - Flags: feedback?(mzehe)

Comment on attachment 9050935 [details]
Bug 1535263 - Move role=combobox from the input field to a parent node.

See my comment in Phabricator.

Attachment #9050935 - Flags: feedback?(mzehe) → feedback+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df7a6846edf5
Move role=combobox from the input field to a parent node. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.