1535274 - Basket emails can be sent to an incorrect email address after primary address changed on FxA

Status: UNCONFIRMED

(Marketing :: Email, defect)

Description

[TOURCODER]

Attachment: Screen-Shot-2019-03-14-at-18.20.40.jpg

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

1. Sign Up with an email address, such as [e-mail]
2. Add a secondary email in that account, suach as [e-mail]
3. Set [e-mail] as primary email address
4. Delete the old one, here is first@firefox, only keep [e-mail]
5. You will find that all emails from firefox or mozilla were sent to [e-mail], not [e-mail].

Actual results:

All emails from firefox or mozilla were sent to [e-mail] which is not in the account, and the primary email address in that account never gets any email.

Expected results:

The old email address should not get the emails, and the primary email should get the emails.

Comment 1

[Ryan Kelly [:rfkelly]]

cloud-services-security → mozilla-employee-confidential

It's not clear from the context whether we're ruled out a security issue here; the report makes it sounds like we're straight-up sending emails to the wrong address, possibly by reading the original account address from accounts.email (where we keep it around for password-hashing purposes) rather than from the emails table.

Comment 2

[Ryan Kelly [:rfkelly]]

Actually, from the screenshot it looks like this is one of the emails sent from Salesforce rather than one sent directly from FxA, so I wonder if the change in primary email address has not propagated correctly to that system.

Comment 3

[Shane Tomlinson [:stomlinson]]

I queried :pmac about this, and this is a paraphrased response:

The marketing team is handling primaryEmailChanged events, but not by changing
the email field associated with the user. Rather because of the limitations of
the way data is stored in their systems, a record of the email change is stored
in a separate table. When emails are sent, it is the responsibility of the
email writer to join the two tables to ensure the correct email is used,
and it's easy to forget to do this.

Comment 4

[Paul [:pmac] McLanahan]

Also note that these are newsletter emails, and a user may well not want their email address for all Mozilla newsletters to change just because their FxA account email did. Having newsletter management in multiple places (www.m.o and FxA e.g.) has made things somewhat confusing for the user in this regard.

Comment 5

[Shane Tomlinson [:stomlinson]]

Removing the security sensitive flag, the problem here can be made public.