Remove some unnecessary namespace qualification in Document.h

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

No description provided.
Assignee

Comment 1

3 months ago

Only kept the ones needed to not conflict with method names.

Comment 2

3 months ago
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99cde26aca85
Remove some unnecessary namespace qualification in Document.h r=smaug

Backed out changeset 99cde26aca85 (Bug 1535297) for build bustage failure in builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Document.h

Failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=233895254

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233895254&repo=autoland&lineNumber=11957

[task 2019-03-14T14:54:37.574Z] 14:54:37 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'xpcom/base/target' failed
[task 2019-03-14T14:54:37.575Z] 14:54:37 ERROR - make[3]: *** [xpcom/base/target] Error 2
[task 2019-03-14T14:54:38.619Z] 14:54:38 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/threads'
[task 2019-03-14T14:54:38.619Z] 14:54:38 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o Unified_cpp_xpcom_threads1.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/xpcom/threads -I/builds/worker/workspace/build/src/obj-firefox/xpcom/threads -I/builds/worker/workspace/build/src/xpcom/build -I/builds/worker/workspace/build/src/caps -I/builds/worker/workspace/build/src/tools/profiler -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -MD -MP -MF .deps/Unified_cpp_xpcom_threads1.o.pp /builds/worker/workspace/build/src/obj-firefox/xpcom/threads/Unified_cpp_xpcom_threads1.cpp
[task 2019-03-14T14:54:38.619Z] 14:54:38 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BindingUtils.h:34:0,
[task 2019-03-14T14:54:38.619Z] 14:54:38 INFO - from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/GeneratedAtomList.h:6,
[task 2019-03-14T14:54:38.619Z] 14:54:38 INFO - from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/AtomList.h:11,
[task 2019-03-14T14:54:38.619Z] 14:54:38 INFO - from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/CycleCollectedJSContext.h:16,
[task 2019-03-14T14:54:38.619Z] 14:54:38 INFO - from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/CustomElementRegistry.h:13,
[task 2019-03-14T14:54:38.619Z] 14:54:38 INFO - from /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/DocGroup.h:17,
[task 2019-03-14T14:54:38.619Z] 14:54:38 INFO - from /builds/worker/workspace/build/src/xpcom/threads/nsThread.h:27,
[task 2019-03-14T14:54:38.619Z] 14:54:38 INFO - from /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.h:12,
[task 2019-03-14T14:54:38.619Z] 14:54:38 INFO - from /builds/worker/workspace/build/src/xpcom/threads/ThreadEventTarget.cpp:14,
[task 2019-03-14T14:54:38.620Z] 14:54:38 INFO - from /builds/worker/workspace/build/src/obj-firefox/xpcom/threads/Unified_cpp_xpcom_threads1.cpp:11:
[task 2019-03-14T14:54:38.620Z] 14:54:38 ERROR - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Document.h:1815:56: error: declaration of 'mozilla::dom::ScriptLoader* mozilla::dom::Document::ScriptLoader()' [-fpermissive]
[task 2019-03-14T14:54:38.620Z] 14:54:38 INFO - ScriptLoader* ScriptLoader() { return mScriptLoader; }
[task 2019-03-14T14:54:38.620Z] 14:54:38 INFO - ^
[task 2019-03-14T14:54:38.620Z] 14:54:38 ERROR - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Document.h:194:7: error: changes meaning of 'ScriptLoader' from 'class mozilla::dom::ScriptLoader' [-fpermissive]
[task 2019-03-14T14:54:38.620Z] 14:54:38 INFO - class ScriptLoader;
[task 2019-03-14T14:54:38.620Z] 14:54:38 INFO - ^~~~~~~~~~~~
[task 2019-03-14T14:54:38.620Z] 14:54:38 INFO - /builds/worker/workspace/build/src/config/rules.mk:805: recipe for target 'Unified_cpp_xpcom_threads1.o' failed
[task 2019-03-14T14:54:38.620Z] 14:54:38 ERROR - make[4]: *** [Unified_cpp_xpcom_threads1.o] Error 1
[task 2019-03-14T14:54:38.620Z] 14:54:38 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/threads'
[task 2019-03-14T14:54:38.620Z] 14:54:38 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'xpcom/threads/target' failed
[task 2019-03-14T14:54:38.620Z] 14:54:38 ERROR - make[3]: *** [xpcom/threads/target] Error 2
[task 2019-03-14T14:54:43.345Z] 14:54:43 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/components'
[task 2019-03-14T14:54:43.345Z] 14:54:43 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -o StaticComponents.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/xpcom/components -I/builds/worker/workspace/build/src/obj-firefox/xpcom/components -I/builds/worker/workspace/build/src/obj-firefox/xpcom -I/builds/worker/workspace/build/src/xpcom/base -I/builds/worker/workspace/build/src/xpcom/build -I/builds/worker/workspace/build/src/xpcom/ds -I/builds/worker/workspace/build/src/chrome -I/builds/worker/workspace/build/src/js/xpconnect/loader -I/builds/worker/workspace/build/src/layout/build -I/builds/worker/workspace/build/src/modules/libjar -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/build/src/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gtk-3.0/unix-print -MD -MP -MF .deps/StaticComponents.o.pp /builds/worker/workspace/build/src/obj-firefox/xpcom/components/StaticComponents.cpp
[task 2019-03-14T14:54:43.345Z] 14:54:43 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/dist/include/nsContentUtils.h:47:0,
[task 2019-03-14T14:54:43.345Z] 14:54:43 INFO - from /builds/worker/workspace/build/src/obj-firefox/xpcom/components/StaticComponents.cpp:17:
[task 2019-03-14T14:54:43.345Z] 14:54:43 ERROR - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Document.h:1815:56: error: declaration of 'mozilla::dom::ScriptLoader* mozilla::dom::Document::ScriptLoader()' [-fpermissive]
[task 2019-03-14T14:54:43.345Z] 14:54:43 INFO - ScriptLoader* ScriptLoader() { return mScriptLoader; }
[task 2019-03-14T14:54:43.345Z] 14:54:43 INFO - ^
[task 2019-03-14T14:54:43.345Z] 14:54:43 ERROR - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Document.h:194:7: error: changes meaning of 'ScriptLoader' from 'class mozilla::dom::ScriptLoader' [-fpermissive]
[task 2019-03-14T14:54:43.346Z] 14:54:43 INFO - class ScriptLoader;
[task 2019-03-14T14:54:43.346Z] 14:54:43 INFO - ^~~~~~~~~~~~
[task 2019-03-14T14:54:43.346Z] 14:54:43 INFO - /builds/worker/workspace/build/src/config/rules.mk:805: recipe for target 'StaticComponents.o' failed
[task 2019-03-14T14:54:43.346Z] 14:54:43 ERROR - make[4]: *** [StaticComponents.o] Error 1
[task 2019-03-14T14:54:43.346Z] 14:54:43 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/components'
[task 2019-03-14T14:54:43.346Z] 14:54:43 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'xpcom/components/target' failed
[task 2019-03-14T14:54:43.346Z] 14:54:43 ERROR - make[3]: *** [xpcom/components/target] Error 2
[task 2019-03-14T14:55:11.495Z] 14:55:11 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/media/ffvpx/libavcodec/x86'
[task 2019-03-14T14:55:11.495Z] 14:55:11 INFO - media/ffvpx/libavcodec/x86/vp9itxfm.o

Flags: needinfo?(htsai)

Comment 4

3 months ago
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ccfa8614ddd
Backed out changeset 99cde26aca85 for build bustage failure in builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Document.h

Comment 5

3 months ago
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/5398aeeb552c
Remove some unnecessary namespace qualification in Document.h r=smaug
Assignee

Updated

3 months ago
Assignee: nobody → emilio
Flags: needinfo?(htsai)

Comment 6

3 months ago
bugherder
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.