1535298 - Clearing Site Data fails with LSNG if the user has quota storage for about:pages

Status: VERIFIED FIXED

(Toolkit :: Data Sanitization, defect, P1)

Description

[Johann Hofmann [:johannh]]

I was trying to remove individual site data in about:preferences -> Cookies and Site Data -> Manage Data and it failed with this error:

NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.host]

This is because https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/toolkit/components/cleardata/ClearDataService.jsm#386 is accessing the .host attribute of about:newtab, in my case.

At the very least we should filter out about: URIs here, but I'm also wondering what this entire block's purpose is:

https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/toolkit/components/cleardata/ClearDataService.jsm#370-403

I'm pretty sure that this comment is not accurate. Jan, do you remember why this was done?

[Tracking Requested - why for this release]:
Most users can't remove individual site data anymore.

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Tracking for 67, it would be good to have a fix before the merge to beta next Monday.

Comment 3

[Kestrel]

Selected storage items appear to be removed from disk in my experience, the Manage Cookies and Site Data panel doesn't close though which is confusing and the preferences page has to be refreshed to see the changes.

Comment 4

[Jan Varga [:janv]]

Yes, this is on our radar.

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

I ma moving the tracking flag to 68 as LSNG won't ship in 67.

Comment 7

[Andrew Overholt [:overholt]]

Tom, can you take this bug?

Comment 8

[Tom Tung [:tt, :ttung]]

Sure

Comment 9

[Tom Tung [:tt, :ttung]]

Note that the internal origins like "about:xxx" won't be collected by listInitializedOrigins() so the minimum requirement has been down.

I'm looking into the behavior of Cookie and Quota stuff. They should be removed together while removing any given origins.

Comment 10

[Tom Tung [:tt, :ttung]]

(In reply to Tom Tung [:tt, :ttung] from comment #9)

Note that the internal origins like "about:xxx" won't be collected by listInitializedOrigins() so the minimum requirement has been down.

In fact, about:newtab doesn't be treated as an internal origin now.

Comment 11

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1535298 - Capture and ignore the exception for not having a host from a principal URI;

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9437ce7f56f1
Capture and ignore the exception for not having a host from a principal URI; r=janv,johannh

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9437ce7f56f1

Comment 14

[Tom Tung [:tt, :ttung]]

Hi Kestrel,

Would you mind helping me to verify if the problem is fixed by testing the latest Nightly? It works on my laptop and I believe the problem is resolved.

Comment 15

[Kestrel]

I can verify this is fixed on Nightly 68.0a1 (2019-05-14) using a profile that has about:newtab storage, the Manage Cookies and Site Data dialog correctly closes after removing a storage item and there is no error in browser console.

Comment 16

[Tom Tung [:tt, :ttung]]

(In reply to Kestrel from comment #15)

I can verify this is fixed on Nightly 68.0a1 (2019-05-14) using a profile that has about:newtab storage, the Manage Cookies and Site Data dialog correctly closes after removing a storage item and there is no error in browser console.

Thanks!