1535357 - Make nsHttpConnectionInfo::Clone() return already_AddRefed<>

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement)

Description

[Andrew McCreight [:mccr8]]

I looked at Valentin's patch in bug 1512472, and went through and checked every other place we create a nsHttpConnectionInfo. The Clone method also assigns to a raw pointer. The code as it is looks okay to me, but it could be made more robust by assigning into a RefPtr and returning an already_AddRefed or RefPtr. This will require a minor change to the caller in nsHttpConnectionInfo::CloneAsDirectRoute(), but I think the rest of the callers should work as-is.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1535357 - Make nsHttpConnectionInfo::Clone() return already_AddRefed<>.

This will make it harder for callers of this method to accidentally
leak the connection info.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be4af23f4c1a
Make nsHttpConnectionInfo::Clone() return already_AddRefed<>. r=valentin

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/be4af23f4c1a