1535370 - Use appropriate schedulerId, scopes in nss decision tasks

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

The schedulerId is currently set to gecko-level-nss, for which nobody has scopes. This doesn't cause issues because the task also doesn't have a priority, meaning it uses "legacyScopes" as described in the api docs. Someday we may want to add a priority, though, so let's remove this footgun.

The appropriate schedulerId is, I think, nss-level-{level}.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1535370 - add trust-domain-scopes for nss to get nss schedulerIds r=mt

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1535370 - use schedulerId nss-level-{level}; r=mt

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1535370 - drop unnecessary queue:route:notify.. route from decision task; r=mt

Depends on D23544

Comment 5

[J.C. Jones [:jcj] (he/him)]

Landed on default as:

https://hg.mozilla.org/projects/nss/rev/f8c73e2b1b6e73ebbd6a9745d7db78b6325d50cf
https://hg.mozilla.org/projects/nss/rev/e8136553ef86fb9dd04119ee66014f624fbcf18d

Will also backport to NSS' ESR and Beta branches shortly.

Comment 6

[J.C. Jones [:jcj] (he/him)]

[push NSS_3_43_BRANCH] https://hg.mozilla.org/projects/nss/rev/215df21bafd0 — Dustin J. Mitchell — Bug 1535370 - Fix NSS CI for old branches [3.43] r=jcj

Comment 7

[J.C. Jones [:jcj] (he/him)]

NSS_3_36_BRANCH: https://hg.mozilla.org/projects/nss/rev/be6a28956a8f28323384667675789b3e40b498a5