Closed Bug 1535378 Opened 6 years ago Closed 6 years ago

Write tests for serialization of principals

Categories

(Core :: DOM: Security, enhancement, P2)

65 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jkt, Assigned: jkt)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

Currently we don't have any tests that explicitly test just the serialization and deserialization of principals (there is a Talos tests however as it currently stands we will fall back to null principals here anyway).

The idea is to:

  1. Create some manual principals and check that they output the correct current version of the principal.
  2. Take some real serialized principals and check all the properties are deserialized correctly.

Changing the serialization:

  1. tests will need to be rewritten when the shape of serialization happens.
  2. tests should be resilient to the changes in the serialization.
Priority: -- → P2
Whiteboard: [domsecurity-active]
Pushed by jkingston@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dab3dbd695e8 Adding a test for the serialization of principals r=ckerschb,mikedeboer
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: