Remove autocomplete-did-enter-text and associated code once QuantumBar ships
Categories
(Firefox :: Address Bar, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: standard8, Assigned: mak)
References
Details
(Whiteboard: [fxsearch])
Attachments
(2 files)
Once QuantumBar ships we should remove the "autocomplete-did-enter-text" observer notification and its subscribers - we don't need them, they have been re-implemented in QuantumBar or other code.
|
||
Comment 1•5 years ago
|
||
The federated learning experiment is using autocomplete-did-enter-text iirc, or at least they were at one point. We should check with them before removing it.
|
Reporter | |
Comment 2•5 years ago
|
||
(In reply to Drew Willcoxon :adw from comment #1)
The federated learning experiment is using autocomplete-did-enter-text iirc, or at least they were at one point. We should check with them before removing it.
I just checked the code, and they're not using it. In any case they'd need to do at least some significant changes for QuantumBar so I would say we'd work out what they need at that time.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
form autofill uses autocomplete-will-enter-text, and passwordmgr uses autocomplete-did-enter-text... So we can't remove them completely.
We can remove the Places side of "autocomplete-will-enter-text", and I think there's some leftover in WebNavigation.jsm for autocomplete-did-enter-text.
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D51280
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/254acf203ee5 Remove handling of autocomplete-will-enter-text from Places. r=Standard8 https://hg.mozilla.org/integration/autoland/rev/a6c4b304fbb5 Remove handling of autocomplete-did-enter-text from WebNavigation. r=Standard8
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/254acf203ee5
https://hg.mozilla.org/mozilla-central/rev/a6c4b304fbb5
Description
•