1535384 - Eliminate some MOZ_CAN_RUN_SCRIPT_BOUNDARY annotations from webidl callbacks

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 1. Eliminate some easy cases of MOZ_CAN_RUN_SCRIPT_BOUNDARY on webidl callbacks. r=mccr8

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 2. Eliminate MOZ_CAN_RUN_SCRIPT_BOUNDARY on some webrtc callbacks. r=jib

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 3. Eliminate MOZ_CAN_RUN_SCRIPT_BOUNDARY on console callbacks. r=baku

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 4. Eliminate MOZ_CAN_RUN_SCRIPT_BOUNDARY for the reporting observer callback. r=baku

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 5. Eliminate MOZ_CAN_RUN_SCRIPT_BOUNDARY for mutation callbacks. r=mccr8

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 6. Get rid of MOZ_CAN_RUN_SCRIPT_BOUNDARY for webaudio callbacks. r=mccr8

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 7. Get rid of MOZ_CAN_RUN_SCRIPT_BOUNDARY for filesystem callbacks. r=mccr8

I'm a bit torn between the const-member-and-MOZ_KnownLive approach
here and just taking extra stack refs...

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 8. Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for Web IDL Function. r=mccr8

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 9. Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for u2f callbacks. r=mccr8

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 10. Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for FontFaceSetForEachCallback. r=heycam

This code should all go away (bug 1311198), but in the meantime...

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 11. Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for getUserMedia callbacks. r=jib

nsIDOMGetUserMediaErrorCallback, nsIDOMGetUserMediaSuccessCallback,
and nsIGetUserMediaDevicesSuccessCallback were completely unused, so
they could just go away and all the code got simpler.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 12. Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY from FrameRequestCallback. r=mccr8

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 13. Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY from IdleRequestCallback. r=farre

Comment 14

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1535384 part 14. Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY from PlacesEventCallback. r=dthayer

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef6d1980e246
part 1.  Eliminate some easy cases of MOZ_CAN_RUN_SCRIPT_BOUNDARY on webidl callbacks.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/b8d0c94d6af8
part 2.  Eliminate MOZ_CAN_RUN_SCRIPT_BOUNDARY on some webrtc callbacks.  r=jib
https://hg.mozilla.org/integration/autoland/rev/e44e37b00bfa
part 3.  Eliminate MOZ_CAN_RUN_SCRIPT_BOUNDARY on console callbacks.  r=baku
https://hg.mozilla.org/integration/autoland/rev/ccee8ba8a8db
part 4.  Eliminate MOZ_CAN_RUN_SCRIPT_BOUNDARY for the reporting observer callback.  r=baku
https://hg.mozilla.org/integration/autoland/rev/099d6c36e831
part 5.  Eliminate MOZ_CAN_RUN_SCRIPT_BOUNDARY for mutation callbacks.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/e3aee48af10f
part 6.  Get rid of MOZ_CAN_RUN_SCRIPT_BOUNDARY for webaudio callbacks.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/b4986880eb50
part 7.  Get rid of MOZ_CAN_RUN_SCRIPT_BOUNDARY for filesystem callbacks.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/49f3f82efca1
part 8.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for Web IDL Function.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/4275dbf74afe
part 9.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for u2f callbacks.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a2ff272ceb42
part 10.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for FontFaceSetForEachCallback.  r=heycam
https://hg.mozilla.org/integration/autoland/rev/db29f053e54e
part 11.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for getUserMedia callbacks.  r=jib
https://hg.mozilla.org/integration/autoland/rev/0502c7a595b2
part 12.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY from FrameRequestCallback.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/f98f97f5f8e6
part 13.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY from IdleRequestCallback.  r=farre
https://hg.mozilla.org/integration/autoland/rev/4959d496cfe3
part 14.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY from PlacesEventCallback.  r=dthayer

Comment 16

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ef6d1980e246
https://hg.mozilla.org/mozilla-central/rev/b8d0c94d6af8
https://hg.mozilla.org/mozilla-central/rev/e44e37b00bfa
https://hg.mozilla.org/mozilla-central/rev/ccee8ba8a8db
https://hg.mozilla.org/mozilla-central/rev/099d6c36e831
https://hg.mozilla.org/mozilla-central/rev/e3aee48af10f
https://hg.mozilla.org/mozilla-central/rev/b4986880eb50
https://hg.mozilla.org/mozilla-central/rev/49f3f82efca1
https://hg.mozilla.org/mozilla-central/rev/4275dbf74afe
https://hg.mozilla.org/mozilla-central/rev/a2ff272ceb42
https://hg.mozilla.org/mozilla-central/rev/db29f053e54e
https://hg.mozilla.org/mozilla-central/rev/0502c7a595b2
https://hg.mozilla.org/mozilla-central/rev/f98f97f5f8e6
https://hg.mozilla.org/mozilla-central/rev/4959d496cfe3