Closed Bug 1535384 Opened 1 year ago Closed 1 year ago

Eliminate some MOZ_CAN_RUN_SCRIPT_BOUNDARY annotations from webidl callbacks

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(14 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
No description provided.
Priority: -- → P2

I'm a bit torn between the const-member-and-MOZ_KnownLive approach
here and just taking extra stack refs...

This code should all go away (bug 1311198), but in the meantime...

nsIDOMGetUserMediaErrorCallback, nsIDOMGetUserMediaSuccessCallback,
and nsIGetUserMediaDevicesSuccessCallback were completely unused, so
they could just go away and all the code got simpler.

Attachment #9051486 - Attachment description: Bug 1535384 part 14. Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY from PlacesEventCallback. r=dothayer → Bug 1535384 part 14. Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY from PlacesEventCallback. r=dthayer
Blocks: 1536336
Depends on: 1535124
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef6d1980e246
part 1.  Eliminate some easy cases of MOZ_CAN_RUN_SCRIPT_BOUNDARY on webidl callbacks.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/b8d0c94d6af8
part 2.  Eliminate MOZ_CAN_RUN_SCRIPT_BOUNDARY on some webrtc callbacks.  r=jib
https://hg.mozilla.org/integration/autoland/rev/e44e37b00bfa
part 3.  Eliminate MOZ_CAN_RUN_SCRIPT_BOUNDARY on console callbacks.  r=baku
https://hg.mozilla.org/integration/autoland/rev/ccee8ba8a8db
part 4.  Eliminate MOZ_CAN_RUN_SCRIPT_BOUNDARY for the reporting observer callback.  r=baku
https://hg.mozilla.org/integration/autoland/rev/099d6c36e831
part 5.  Eliminate MOZ_CAN_RUN_SCRIPT_BOUNDARY for mutation callbacks.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/e3aee48af10f
part 6.  Get rid of MOZ_CAN_RUN_SCRIPT_BOUNDARY for webaudio callbacks.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/b4986880eb50
part 7.  Get rid of MOZ_CAN_RUN_SCRIPT_BOUNDARY for filesystem callbacks.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/49f3f82efca1
part 8.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for Web IDL Function.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/4275dbf74afe
part 9.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for u2f callbacks.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a2ff272ceb42
part 10.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for FontFaceSetForEachCallback.  r=heycam
https://hg.mozilla.org/integration/autoland/rev/db29f053e54e
part 11.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY for getUserMedia callbacks.  r=jib
https://hg.mozilla.org/integration/autoland/rev/0502c7a595b2
part 12.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY from FrameRequestCallback.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/f98f97f5f8e6
part 13.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY from IdleRequestCallback.  r=farre
https://hg.mozilla.org/integration/autoland/rev/4959d496cfe3
part 14.  Remove MOZ_CAN_RUN_SCRIPT_BOUNDARY from PlacesEventCallback.  r=dthayer
You need to log in before you can comment on or make changes to this bug.