Picture-in-Picture window should resize when the video changes dimensions
Categories
(Toolkit :: Video/Audio Controls, defect, P3)
Tracking
()
People
(Reporter: mconley, Assigned: mstriemer)
References
Details
Attachments
(3 files)
STR:
- Visit https://www.youtube.com/watch?v=sb3FJdRk-tI
- Hopefully an advertisement plays first (or else these STR aren't going to work). While the advertisement is playing, right-click on the video and choose "Picture in Picture" to open the Pciture-in-Picture window.
- Click "Skip ad" in the original video.
ER:
When the video starts playing the Jane's Addiction music video, the video resizes. The Picture-in-Picture window should change dimensions accordingly (within the limits of the window size).
AR:
The Picture-in-Picture window keeps it's original dimensions.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 1•5 years ago
|
||
Reporter | ||
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Reproducible on latest Nightly 71 and Beta 70.0b7, updating flags.
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46b4eb05f2ae Part 1: Allow windows to resize outside of aspect ratio locking on Windows r=jmathies https://hg.mozilla.org/integration/autoland/rev/bc637c20c7d4 Part 2: Resize PiP window when video source resizes r=mconley
Comment 7•5 years ago
|
||
Backed out 3 changesets (bug 1535437, bug 1591253) for causing browser_resizeVideo.js to permafail
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-6%2Cm%28bc6%29&revision=f7cc2f6d9640820f5278bbc7787ccae542e06e69
backout: https://hg.mozilla.org/integration/autoland/rev/96b4cb315770c2037cb2cee9c7ffd76ef252ed2b
Comment 8•5 years ago
|
||
Build ID 20191124230652
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:72.0) Gecko/20100101 Firefox/72.0
Reproducible also on Nightly 72 on macOS 10.13 platform.
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d5a82a15e3a5 Part 1: Allow windows to resize outside of aspect ratio locking on Windows r=jmathies https://hg.mozilla.org/integration/autoland/rev/d95a64f744b0 Part 2: Resize PiP window when video source resizes r=mconley
Comment 10•4 years ago
|
||
Backed out for perma fails on browser_resizeVideo.js
Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=279634485&resultStatus=testfailed%2Cbusted%2Cexception&revision=8222591127e990a6339945c9c97aed20c213e44f
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279634485&repo=autoland&lineNumber=66977
Backout: https://hg.mozilla.org/integration/autoland/rev/127593debf3a81cc8089672f4fe2cd372d6ef73e
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/22a3369d6f5e Part 1: Allow windows to resize outside of aspect ratio locking on Windows r=jmathies https://hg.mozilla.org/integration/autoland/rev/c4073c0f964b Part 2: Resize PiP window when video source resizes r=mconley
Comment 12•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/22a3369d6f5e
https://hg.mozilla.org/mozilla-central/rev/c4073c0f964b
Updated•4 years ago
|
Updated•4 years ago
|
Comment 14•4 years ago
|
||
Linux is covered by Bug 1602563
Assignee | ||
Comment 15•4 years ago
|
||
I think since this has some widget layer changes it would be best to let it ride the trains without the uplift.
Comment 16•4 years ago
|
||
Thanks Mark.
Comment 17•2 years ago
|
||
I reproduced it in Nightly v71.0a1 and verified the fix in v100.0a1 in Windows 10, Ubuntu 22 and Mac OS 11.
Description
•