Closed Bug 1535437 Opened 9 months ago Closed 4 days ago

Picture-in-Picture window should resize when the video changes dimensions

Categories

(Toolkit :: Video/Audio Controls, defect, P3)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox69 --- disabled
firefox70 --- disabled
firefox71 --- wontfix
firefox72 --- affected
firefox73 --- fixed

People

(Reporter: mconley, Assigned: mstriemer, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

STR:

  1. Visit https://www.youtube.com/watch?v=sb3FJdRk-tI
  2. Hopefully an advertisement plays first (or else these STR aren't going to work). While the advertisement is playing, right-click on the video and choose "Picture in Picture" to open the Pciture-in-Picture window.
  3. Click "Skip ad" in the original video.

ER:

When the video starts playing the Jane's Addiction music video, the video resizes. The Picture-in-Picture window should change dimensions accordingly (within the limits of the window size).

AR:

The Picture-in-Picture window keeps it's original dimensions.

Assignee: nobody → mconley
Assignee: mconley → nobody
Duplicate of this bug: 1581218

Reproducible on latest Nightly 71 and Beta 70.0b7, updating flags.

Assignee: nobody → mstriemer
Blocks: 1591253
Attachment #9103389 - Attachment description: Bug 1535437 - Resize PiP window when video source resizes r?mconley → Bug 1535437 - Part 2: Resize PiP window when video source resizes r?mconley
Attachment #9106743 - Attachment description: Bug 1535437 - Part 1: Allow windows to resize outside of aspect ratio locking on linux/Windows r?aklotz → Bug 1535437 - Part 1: Allow windows to resize outside of aspect ratio locking on Windows r?aklotz
Attachment #9106743 - Attachment description: Bug 1535437 - Part 1: Allow windows to resize outside of aspect ratio locking on Windows r?aklotz → Bug 1535437 - Part 1: Allow windows to resize outside of aspect ratio locking on Windows r?jamthies
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46b4eb05f2ae
Part 1: Allow windows to resize outside of aspect ratio locking on Windows r=jmathies
https://hg.mozilla.org/integration/autoland/rev/bc637c20c7d4
Part 2: Resize PiP window when video source resizes r=mconley

Build ID 20191124230652
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:72.0) Gecko/20100101 Firefox/72.0

Reproducible also on Nightly 72 on macOS 10.13 platform.

OS: Unspecified → All
Hardware: Unspecified → Desktop
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5a82a15e3a5
Part 1: Allow windows to resize outside of aspect ratio locking on Windows r=jmathies
https://hg.mozilla.org/integration/autoland/rev/d95a64f744b0
Part 2: Resize PiP window when video source resizes r=mconley
Attachment #9106743 - Attachment description: Bug 1535437 - Part 1: Allow windows to resize outside of aspect ratio locking on Windows r?jamthies → Bug 1535437 - Part 1: Allow windows to resize outside of aspect ratio locking on Windows r?jmathies
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22a3369d6f5e
Part 1: Allow windows to resize outside of aspect ratio locking on Windows r=jmathies
https://hg.mozilla.org/integration/autoland/rev/c4073c0f964b
Part 2: Resize PiP window when video source resizes r=mconley
Status: NEW → RESOLVED
Closed: 4 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Flags: needinfo?(mstriemer)

Is this worth uplifting to beta?

Flags: needinfo?(mstriemer)

Linux is covered by Bug 1602563

You need to log in before you can comment on or make changes to this bug.