Closed
Bug 1535441
Opened 5 years ago
Closed 5 years ago
Update Windows clang to 8.0.0final
Categories
(Firefox Build System :: Toolchains, defect)
Firefox Build System
Toolchains
Tracking
(firefox67 fixed, firefox68 fixed)
RESOLVED
FIXED
mozilla68
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
It's expected that rc5 will be the final contents of the 8.0.0 release. It would be nice to get this in before the merge and not have to bother with an uplift.
It's expected that rc5 will be the final contents of the 8.0.0 release.
Updated•5 years ago
|
Attachment #9051105 -
Attachment is obsolete: true
Summary: Update Windows clang to 8.0.0rc5 → Update Windows clang to 8.0.0final
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ca91ac220ca9 Update win64 clang-cl to 8.0.0final r=firefox-build-system-reviewers,chmanchester
Comment 4•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Updated•5 years ago
|
Assignee: nobody → dmajor
Comment on attachment 9052067 [details]
Update win64 clang-cl to 8.0.0final
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: None
- User impact if declined: Ship with a prerelease compiler
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Moves us from a release candidate build of clang to the official release. Gives us better confidence because it's gone through more validation more people are using it, etc.
- String changes made/needed: None
Flags: needinfo?(dmajor)
Attachment #9052067 -
Flags: approval-mozilla-beta?
Comment 7•5 years ago
|
||
Comment on attachment 9052067 [details]
Update win64 clang-cl to 8.0.0final
Building with the final release of Clang instead of an RC makes sense, uplift approved for 67 beta 6, thanks.
Attachment #9052067 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•5 years ago
|
||
bugherder uplift |
status-firefox67:
--- → fixed
Updated•5 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•