Closed Bug 1535465 Opened 6 years ago Closed 6 years ago

Please add Facebook Container to Pontoon

Categories

(Localization Infrastructure and Tools :: Administration / Setup, task)

Product:
Localization Infrastructure and Tools
Component:
Administration / Setup
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: groovecoder, Assigned: flod)

Details

url: https://github.com/mozilla/contain-facebook

target locales: as many Firefox locales as we can get, but definitely the 24(?) official EU languages

description:
from: https://addons.mozilla.org/en-US/firefox/addon/facebook-container/ ...

Installing this extension closes your Facebook tabs, deletes your Facebook cookies, and logs you out of Facebook.
The next time you navigate to Facebook it will load in a new blue colored browser tab (the “Container”).
You can log in and use Facebook normally when in the Facebook Container. If you click on a non-Facebook link or navigate to a non-Facebook website in the URL bar, these pages will load outside of the container.
Clicking Facebook Share buttons on other browser tabs will load them within the Facebook Container. You should know that using these buttons passes information to Facebook about the website that you shared from.

Hi Luke,

Could you help us understand what this bug is asking us to hook into Pontoon: the add-on UI or the README.md? I gave the repo a cursory glance and didn't see any string resource files. If it's the UI we're hooking up here, we need a locales directory with externalized string resource files in any of the following formats:

.po, .ftl, .dtd, .properties, .json

If it's the README.md file, we can send that to a vendor. Also, I'm CC'ing flod (who would manage the UI localization) and Peiying (who would manage the .md file translation) for additional questions.

Thanks,
Jeff

Assignee: nobody → francesco.lodolo
Flags: needinfo?(lcrouch)

(In reply to Jeff Beatty [:gueroJeff] from comment #1)

Could you help us understand what this bug is asking us to hook into Pontoon: the add-on UI or the README.md? I gave the repo a cursory glance and didn't see any string resource files. If it's the UI we're hooking up here, we need a locales directory with externalized string resource files in any of the following formats:

I've asked to file to bug. This is about the add-on localization, which is still in a pull request right now.
https://github.com/mozilla/contain-facebook/pull/195

@Luke
I've asked for a lot more information though (and also to assign the bug directly to me).

  • Project description: will be used in Pontoon, and it needs to be short (i.e. not the AMO description)
  • Details on which branch to use to commit localization
  • URL of the repository
  • Add the Pontoon bot to your repository with write permissions https://github.com/mozilla-pontoon

I can add the EU locales, and manage the rest as opt-in. Again, we don't have all 24 official EU languages.

More questions:

  • Schedule:
    • Any idea when the translated version will be launched?
    • Are we going to block launch on having translations?
    • How often can we update post-launch?
  • Testing:
    • Will there be a testing version available for localizers?

Sorry I fumbled the hand-off from Slack into bugzilla. To the specific points ...

  • Project description: "The Facebook Container extension for Firefox helps you take control and isolate your web activity from Facebook." ?

  • Details on which branch to use to commit: master (seems to be working fine for Monitor)

  • URL of the repository: https://github.com/mozilla/contain-facebook

  • Add the Pontoon bot to your repository with write permissions https://github.com/mozilla-pontoon : done.

  • Schedule:

    • We want to release the first version that includes at least some translations by April 15 (I believe)
    • We won't need to block launch on translations, because I have code that disables the UI if it's not fully translated
    • It's an add-on on AMO so we can release quickly; I predict every couple weeks. There will be at least 1 more "big" release where we add a significant amount of new protection & UI

  • Testing:

    • We don't have an automated build-to-review-online mechanism. :( The only way to test right now is to run web-ext run -s src locally :(
Flags: needinfo?(lcrouch)

Thanks, that's helpful.

There was an open question in the PR, regarding the German text currently in there. Is it something added just for testing?

  • Testing:
    • We don't have an automated build-to-review-online mechanism. :( The only way to test right now is to run web-ext run -s src locally :(

It would be great to figure out if this can be fixed, probably also for QA.

Once the strings are in the PR, and all the initial content is there, we should be able to add it to Pontoon, given that Matjaz already tested it on stage.

(In reply to Francesco Lodolo [:flod] from comment #5)

  • Testing:
    • We don't have an automated build-to-review-online mechanism. :( The only way to test right now is to run web-ext run -s src locally :(

It would be great to figure out if this can be fixed, probably also for QA.

We could modify the Travis CI job for each master merge/commit:

  1. Add a web-ext build step
  2. Create a tag on GitHub
  3. Upload the un-signed .zip to the GitHub tag/release

Translators would still need to download the .zip and load it into a Firefox that allows un-signed extensions. (I.e., Nightly with xpinstall.signatures.required;false)

Alternatively, we could add this to the Travis CI job for each master merge/commit:

  1. Add a web-ext build step
  2. Add a web-ext sign step
  3. Create a tag on GitHub
  4. Upload the signed .zip to the GitHub tag/release

Translators could download & install the .zip straight into a regular Firefox release.

How likely are translators to be able to do the above in order to QA? Is there any way to automatically communicate the tag/release download url to translators? Is there an email alias or list for the entire team?

Flags: needinfo?(francesco.lodolo)

Okay, the src/_locales directory is now available in master branch of the repo.

Is that everything needed from the code side to try adding the repo to Pontoon?

Sync works
https://github.com/mozilla/contain-facebook/commit/055fff4dfa006347a1480f1f1aa30b69ba20b8d6

But while setting up the repository on stage I noticed several issues in comments, and one in the string
https://github.com/mozilla/contain-facebook/issues/216

Flags: needinfo?(francesco.lodolo) → needinfo?(lcrouch)

Sent https://github.com/mozilla/contain-facebook/pull/222 for the issues.

Flags: needinfo?(lcrouch)

With https://github.com/mozilla/contain-facebook/pull/225 merged, we have our final strings merged into master branch. So we can open up the pontoon translation now.

Flags: needinfo?(francesco.lodolo)

Project is enabled
https://pontoon.mozilla.org/projects/facebook-container/

Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(francesco.lodolo)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.