1535574 - Reply to Markdown comment adds extra line above quoted text but not below

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Wayne Mery (:wsmwk)]

+++ This bug was initially created as a clone of Bug #1535521 +++

Problem: text without blank line after quoted material is rendered smashed together with the quoted material, but in email and in BMO page rendering.

Solution: Don't smash reply into the quote. If a blank line is required to make this work, then the "reply" function should supply it, we should not make the user put it in.

But it would be better IMO to render nicely when there is no blank line after the "quote".

Compare these two cases. The first one is made to look like there is no reply.

(In reply to Kohei Yoshino [:kohei] (Bugzilla UX) (FxSiteCompat) from comment #11)

Hey abusers, I listen to you 🤗
No you don't

(In reply to Kohei Yoshino [:kohei] (Bugzilla UX) (FxSiteCompat) from comment #11)

Hey abusers, I listen to you 🤗

No you don't

Comment 1

[Wayne Mery (:wsmwk)]

Attachment: email rendering example

example email. And same as apperance in BMO web page.

(I am joking of course about "you don't listen". Reality is just the opposite.)

Comment 2

[Wayne Mery (:wsmwk)]

bug 1532962 comment 5 is an example

Comment 3

[Kohei Yoshino]

Should be easy to fix.

Comment 5

[Kohei Yoshino]

Attachment: GitHub Pull Request

Comment 6

[Kohei Yoshino]

Merged to master.

Comment 7

[Wayne Mery (:wsmwk)]

Something's not quite right. And very strange because I don't remember seeing this before today.

When I click the reply arrow, there is still a line above the quoted material. And now the cursor is after the last character of the quoted material

Comment 8

[Kohei Yoshino]

We haven’t pushed this to production yet.

Comment 9

[Kohei Yoshino]

Should be live next week :)