1535616 - The Search Widget Bar cannot be resized to 1x1 dimension on Google Pixel devices

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Andrei Bodea[:andrei]]

Environment:

Device: Google Pixel 3 XL(Android P), Google Pixel(Android Q), Google Pixel XL(Android P), Google Pixel 2(Android P)
Build: Latest Nightly 67.0a1.

Steps to reproduce:

1. Install and launch Fennec.
2. Tap on the home button.
3. Add the search widget to the home screen.
4. Tap and hold on the widget.
5. Try to resize the Search Widget until it remains only the icon meaning the 1x1 size.

Expected result:

The search widget bar is resized to 1x1 and only the icon is displayed.

Actual result:

The search widget bar can be resized only until 2x1, the 1x1 is not reachable.

Notes:

This issue occurs only for the Google Pixel Devices. I also tried to reproduce the issue on Samsung Galaxy Note 9(Android 8.1.0), Samsung Galaxy S8(Android 8.1.0).
For more details please see the video.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: FennecSearchWidgetOnPixel.png

Tested this with the help of :andrei and confirmed that we are indeed using the Android recommended values for choosing which layout (with how many cells) to load [1][2] but the Pixel launcher is sending different than normal values.
In this case it is not sending a width smaller than 110 which would normally indicate the need for a 1x1 widget.

Tested also on a Samsung S9 with a similar 1440p screen and saw there that the widget's layout is updated correctly so it seems like the Pixel Launcher is an edgecase which needs special treatment.

[1] https://searchfox.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/search/SearchWidgetProvider.java#94
[2] https://developer.android.com/guide/practices/ui_guidelines/widget_design

Comment 2

[Anuta Logigan]

Attachment: Pixel_Search_Widget.gif

Comment 3

[Anuta Logigan]

Comment on attachment 9071591 [details]
Pixel_Search_Widget.gif

This seems to be a Pixel Launcher specific behaviour, tested on Samsung and Huawei devices and this issue was not reproducible.
It behaves the same for the Google now widget(attaching video).  The Google Crome search widget is not resizable.
I've double checked the implementation[1] and we are using Android recommended[2] values for determining the size and for choosing which layout (with how many cells) to load.
Confirming what Petru wrote above, Pixel luncher is not sending the correct width values. It should send a width smaller than 110 that will indicate the need for a 1x1 widget. The lowest width its sending is 137.
@Andrei Bodea We are closing this as a won't fix.

2019-06-12 14:14:06.491 13895-13895/org.mozilla.fennec_anuta.vlad E/Will use 5 cells for: 291 minWidth
2019-06-12 14:14:06.596 13895-13895/org.mozilla.fennec_anuta.vlad E/Will use 3 cells for: 214 minWidth
2019-06-12 14:14:06.671 13895-13895/org.mozilla.fennec_anuta.vlad E/Will use 2 cells for: 137 minWidth

[1] https://searchfox.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/search/SearchWidgetProvider.java#94
[2] https://developer.android.com/guide/practices/ui_guidelines/widget_design